-
Notifications
You must be signed in to change notification settings - Fork 312
Batch refactor multiple gradle modules name #9615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 4ffac57 | Docs | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1011800
Total [baseline] (8.665 s) : 0, 8664847
Agent [candidate] (1.015 s) : 0, 1014537
Total [candidate] (8.673 s) : 0, 8673095
section iast
Agent [baseline] (1.158 s) : 0, 1158172
Total [baseline] (9.292 s) : 0, 9291690
Agent [candidate] (1.138 s) : 0, 1138348
Total [candidate] (9.29 s) : 0, 9290183
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (692.798 ms) : 0, 692798
BytebuddyAgent [candidate] (693.218 ms) : 0, 693218
GlobalTracer [baseline] (248.739 ms) : 0, 248739
GlobalTracer [candidate] (250.692 ms) : 0, 250692
AppSec [baseline] (31.429 ms) : 0, 31429
AppSec [candidate] (31.715 ms) : 0, 31715
Debugger [baseline] (6.403 ms) : 0, 6403
Debugger [candidate] (6.483 ms) : 0, 6483
Remote Config [baseline] (688.982 µs) : 0, 689
Remote Config [candidate] (714.421 µs) : 0, 714
Telemetry [baseline] (9.083 ms) : 0, 9083
Telemetry [candidate] (9.108 ms) : 0, 9108
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (820.054 ms) : 0, 820054
BytebuddyAgent [candidate] (805.008 ms) : 0, 805008
GlobalTracer [baseline] (239.457 ms) : 0, 239457
GlobalTracer [candidate] (236.245 ms) : 0, 236245
AppSec [baseline] (33.882 ms) : 0, 33882
AppSec [candidate] (33.771 ms) : 0, 33771
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (5.993 ms) : 0, 5993
Remote Config [baseline] (605.481 µs) : 0, 605
Remote Config [candidate] (588.108 µs) : 0, 588
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.203 ms) : 0, 8203
IAST [baseline] (26.619 ms) : 0, 26619
IAST [candidate] (25.881 ms) : 0, 25881
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1002132
Total [baseline] (10.658 s) : 0, 10657501
Agent [candidate] (1.012 s) : 0, 1012270
Total [candidate] (10.729 s) : 0, 10728974
section appsec
Agent [baseline] (1.188 s) : 0, 1188037
Total [baseline] (10.941 s) : 0, 10940858
Agent [candidate] (1.184 s) : 0, 1184424
Total [candidate] (10.97 s) : 0, 10969828
section iast
Agent [baseline] (1.147 s) : 0, 1146691
Total [baseline] (10.869 s) : 0, 10868785
Agent [candidate] (1.143 s) : 0, 1142526
Total [candidate] (10.993 s) : 0, 10993375
section profiling
Agent [baseline] (1.153 s) : 0, 1152727
Total [baseline] (11.022 s) : 0, 11021993
Agent [candidate] (1.15 s) : 0, 1150258
Total [candidate] (11.006 s) : 0, 11005972
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (686.24 ms) : 0, 686240
BytebuddyAgent [candidate] (693.205 ms) : 0, 693205
GlobalTracer [baseline] (246.477 ms) : 0, 246477
GlobalTracer [candidate] (249.111 ms) : 0, 249111
AppSec [baseline] (30.866 ms) : 0, 30866
AppSec [candidate] (31.265 ms) : 0, 31265
Debugger [baseline] (6.333 ms) : 0, 6333
Debugger [candidate] (6.434 ms) : 0, 6434
Remote Config [baseline] (678.687 µs) : 0, 679
Remote Config [candidate] (700.94 µs) : 0, 701
Telemetry [baseline] (8.85 ms) : 0, 8850
Telemetry [candidate] (8.919 ms) : 0, 8919
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (712.315 ms) : 0, 712315
BytebuddyAgent [candidate] (710.047 ms) : 0, 710047
GlobalTracer [baseline] (240.038 ms) : 0, 240038
GlobalTracer [candidate] (239.335 ms) : 0, 239335
AppSec [baseline] (172.496 ms) : 0, 172496
AppSec [candidate] (172.17 ms) : 0, 172170
Debugger [baseline] (5.97 ms) : 0, 5970
Debugger [candidate] (6.691 ms) : 0, 6691
Remote Config [baseline] (644.572 µs) : 0, 645
Remote Config [candidate] (641.89 µs) : 0, 642
Telemetry [baseline] (9.252 ms) : 0, 9252
Telemetry [candidate] (8.446 ms) : 0, 8446
IAST [baseline] (24.67 ms) : 0, 24670
IAST [candidate] (24.535 ms) : 0, 24535
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (810.053 ms) : 0, 810053
BytebuddyAgent [candidate] (808.14 ms) : 0, 808140
GlobalTracer [baseline] (238.315 ms) : 0, 238315
GlobalTracer [candidate] (236.788 ms) : 0, 236788
AppSec [baseline] (33.921 ms) : 0, 33921
AppSec [candidate] (33.047 ms) : 0, 33047
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (598.468 µs) : 0, 598
Remote Config [candidate] (597.62 µs) : 0, 598
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.326 ms) : 0, 8326
IAST [baseline] (26.327 ms) : 0, 26327
IAST [candidate] (26.775 ms) : 0, 26775
section profiling
ProfilingAgent [baseline] (101.087 ms) : 0, 101087
ProfilingAgent [candidate] (101.645 ms) : 0, 101645
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (718.099 ms) : 0, 718099
BytebuddyAgent [candidate] (717.139 ms) : 0, 717139
GlobalTracer [baseline] (224.867 ms) : 0, 224867
GlobalTracer [candidate] (223.197 ms) : 0, 223197
AppSec [baseline] (31.408 ms) : 0, 31408
AppSec [candidate] (31.288 ms) : 0, 31288
Debugger [baseline] (6.556 ms) : 0, 6556
Debugger [candidate] (6.502 ms) : 0, 6502
Remote Config [baseline] (732.54 µs) : 0, 733
Remote Config [candidate] (713.933 µs) : 0, 714
Telemetry [baseline] (16.261 ms) : 0, 16261
Telemetry [candidate] (15.431 ms) : 0, 15431
Profiling [baseline] (101.669 ms) : 0, 101669
Profiling [candidate] (102.879 ms) : 0, 102879
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (4.324 ms) : 4275, 4373
. : milestone, 4324,
iast (9.952 ms) : 9788, 10116
. : milestone, 9952,
iast_FULL (14.114 ms) : 13833, 14394
. : milestone, 14114,
iast_GLOBAL (10.104 ms) : 9919, 10289
. : milestone, 10104,
profiling (8.87 ms) : 8722, 9017
. : milestone, 8870,
tracing (7.722 ms) : 7612, 7832
. : milestone, 7722,
section candidate
no_agent (4.42 ms) : 4358, 4482
. : milestone, 4420,
iast (9.89 ms) : 9725, 10055
. : milestone, 9890,
iast_FULL (13.755 ms) : 13480, 14029
. : milestone, 13755,
iast_GLOBAL (10.242 ms) : 10064, 10420
. : milestone, 10242,
profiling (8.753 ms) : 8605, 8900
. : milestone, 8753,
tracing (7.541 ms) : 7435, 7646
. : milestone, 7541,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (35.361 ms) : 35079, 35642
. : milestone, 35361,
appsec (47.693 ms) : 47277, 48109
. : milestone, 47693,
code_origins (42.512 ms) : 42164, 42860
. : milestone, 42512,
iast (44.411 ms) : 44035, 44787
. : milestone, 44411,
profiling (49.099 ms) : 48590, 49608
. : milestone, 49099,
tracing (44.514 ms) : 44125, 44903
. : milestone, 44514,
section candidate
no_agent (37.17 ms) : 36863, 37476
. : milestone, 37170,
appsec (49.197 ms) : 48769, 49626
. : milestone, 49197,
code_origins (43.761 ms) : 43374, 44149
. : milestone, 43761,
iast (44.652 ms) : 44270, 45034
. : milestone, 44652,
profiling (48.93 ms) : 48487, 49372
. : milestone, 48930,
tracing (45.524 ms) : 45134, 45914
. : milestone, 45524,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
appsec (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
iast (18.628 s) : 18628000, 18628000
. : milestone, 18628000,
iast_GLOBAL (17.923 s) : 17923000, 17923000
. : milestone, 17923000,
profiling (16.152 s) : 16152000, 16152000
. : milestone, 16152000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
section candidate
no_agent (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.309 s) : 18309000, 18309000
. : milestone, 18309000,
iast_GLOBAL (18.02 s) : 18020000, 18020000
. : milestone, 18020000,
profiling (15.784 s) : 15784000, 15784000
. : milestone, 15784000,
tracing (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ffac573bc, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.716 ms) : 3498, 3934
. : milestone, 3716,
iast (2.206 ms) : 2143, 2269
. : milestone, 2206,
iast_GLOBAL (2.249 ms) : 2185, 2312
. : milestone, 2249,
profiling (2.485 ms) : 2315, 2655
. : milestone, 2485,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.46 ms) : 2409, 2510
. : milestone, 2460,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.072 ms) : 2020, 2124
. : milestone, 2072,
tracing (2.023 ms) : 1974, 2072
. : milestone, 2023,
|
What Does This Do
Group gradle modules according to new conventions. Commits are separated for a better tracking
Also merges log4j-logs-intake with log4j-2.0
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]