-
Notifications
You must be signed in to change notification settings - Fork 312
Update smoke test tasks to use lazy API #9617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update smoke test tasks to use lazy API #9617
Conversation
🎯 Code Coverage 🔗 Commit SHA: 6b5709a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1011986
Total [baseline] (8.682 s) : 0, 8681954
Agent [candidate] (1.013 s) : 0, 1013091
Total [candidate] (8.658 s) : 0, 8658086
section iast
Agent [baseline] (1.145 s) : 0, 1144569
Total [baseline] (9.239 s) : 0, 9238823
Agent [candidate] (1.142 s) : 0, 1141926
Total [candidate] (9.205 s) : 0, 9204604
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (692.387 ms) : 0, 692387
BytebuddyAgent [candidate] (693.701 ms) : 0, 693701
GlobalTracer [baseline] (248.854 ms) : 0, 248854
GlobalTracer [candidate] (249.128 ms) : 0, 249128
AppSec [baseline] (31.648 ms) : 0, 31648
AppSec [candidate] (31.354 ms) : 0, 31354
Debugger [baseline] (6.532 ms) : 0, 6532
Debugger [candidate] (6.453 ms) : 0, 6453
Remote Config [baseline] (686.644 µs) : 0, 687
Remote Config [candidate] (688.036 µs) : 0, 688
Telemetry [baseline] (9.15 ms) : 0, 9150
Telemetry [candidate] (9.127 ms) : 0, 9127
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (809.572 ms) : 0, 809572
BytebuddyAgent [candidate] (807.956 ms) : 0, 807956
GlobalTracer [baseline] (237.022 ms) : 0, 237022
GlobalTracer [candidate] (236.844 ms) : 0, 236844
IAST [baseline] (26.241 ms) : 0, 26241
IAST [candidate] (26.07 ms) : 0, 26070
AppSec [baseline] (34.228 ms) : 0, 34228
AppSec [candidate] (33.49 ms) : 0, 33490
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.029 ms) : 0, 6029
Remote Config [baseline] (585.83 µs) : 0, 586
Remote Config [candidate] (591.383 µs) : 0, 591
Telemetry [baseline] (8.275 ms) : 0, 8275
Telemetry [candidate] (8.281 ms) : 0, 8281
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015033
Total [baseline] (10.817 s) : 0, 10817264
Agent [candidate] (1.007 s) : 0, 1006565
Total [candidate] (10.681 s) : 0, 10681471
section appsec
Agent [baseline] (1.189 s) : 0, 1188534
Total [baseline] (11.027 s) : 0, 11026586
Agent [candidate] (1.195 s) : 0, 1194527
Total [candidate] (10.982 s) : 0, 10981741
section iast
Agent [baseline] (1.152 s) : 0, 1152440
Total [baseline] (11.017 s) : 0, 11016532
Agent [candidate] (1.143 s) : 0, 1143003
Total [candidate] (10.93 s) : 0, 10929804
section profiling
Agent [baseline] (1.15 s) : 0, 1149505
Total [baseline] (11.041 s) : 0, 11041198
Agent [candidate] (1.161 s) : 0, 1160646
Total [candidate] (11.004 s) : 0, 11003950
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (694.281 ms) : 0, 694281
BytebuddyAgent [candidate] (689.192 ms) : 0, 689192
GlobalTracer [baseline] (249.836 ms) : 0, 249836
GlobalTracer [candidate] (247.708 ms) : 0, 247708
AppSec [baseline] (31.879 ms) : 0, 31879
AppSec [candidate] (31.143 ms) : 0, 31143
Debugger [baseline] (6.54 ms) : 0, 6540
Debugger [candidate] (6.345 ms) : 0, 6345
Remote Config [baseline] (699.05 µs) : 0, 699
Remote Config [candidate] (665.095 µs) : 0, 665
Telemetry [baseline] (9.139 ms) : 0, 9139
Telemetry [candidate] (8.98 ms) : 0, 8980
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (712.648 ms) : 0, 712648
BytebuddyAgent [candidate] (717.162 ms) : 0, 717162
GlobalTracer [baseline] (239.928 ms) : 0, 239928
GlobalTracer [candidate] (240.82 ms) : 0, 240820
IAST [baseline] (24.698 ms) : 0, 24698
IAST [candidate] (24.849 ms) : 0, 24849
AppSec [baseline] (170.587 ms) : 0, 170587
AppSec [candidate] (172.337 ms) : 0, 172337
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (644.375 µs) : 0, 644
Remote Config [candidate] (641.706 µs) : 0, 642
Telemetry [baseline] (11.471 ms) : 0, 11471
Telemetry [candidate] (10.01 ms) : 0, 10010
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (815.181 ms) : 0, 815181
BytebuddyAgent [candidate] (808.925 ms) : 0, 808925
GlobalTracer [baseline] (238.868 ms) : 0, 238868
GlobalTracer [candidate] (237.126 ms) : 0, 237126
IAST [baseline] (26.281 ms) : 0, 26281
IAST [candidate] (26.948 ms) : 0, 26948
AppSec [baseline] (34.122 ms) : 0, 34122
AppSec [candidate] (32.439 ms) : 0, 32439
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (6.018 ms) : 0, 6018
Remote Config [baseline] (599.125 µs) : 0, 599
Remote Config [candidate] (569.907 µs) : 0, 570
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (8.255 ms) : 0, 8255
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (717.46 ms) : 0, 717460
BytebuddyAgent [candidate] (723.778 ms) : 0, 723778
GlobalTracer [baseline] (223.087 ms) : 0, 223087
GlobalTracer [candidate] (225.386 ms) : 0, 225386
AppSec [baseline] (31.176 ms) : 0, 31176
AppSec [candidate] (31.621 ms) : 0, 31621
Debugger [baseline] (6.506 ms) : 0, 6506
Debugger [candidate] (8.098 ms) : 0, 8098
Remote Config [baseline] (701.35 µs) : 0, 701
Remote Config [candidate] (697.477 µs) : 0, 697
Telemetry [baseline] (16.324 ms) : 0, 16324
Telemetry [candidate] (13.986 ms) : 0, 13986
ProfilingAgent [baseline] (100.56 ms) : 0, 100560
ProfilingAgent [candidate] (103.124 ms) : 0, 103124
Profiling [baseline] (101.146 ms) : 0, 101146
Profiling [candidate] (103.725 ms) : 0, 103725
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 5 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (4.299 ms) : 4249, 4349
. : milestone, 4299,
iast (10.228 ms) : 10054, 10401
. : milestone, 10228,
iast_FULL (14.324 ms) : 14042, 14606
. : milestone, 14324,
iast_GLOBAL (10.335 ms) : 10155, 10516
. : milestone, 10335,
profiling (8.781 ms) : 8643, 8919
. : milestone, 8781,
tracing (7.872 ms) : 7759, 7986
. : milestone, 7872,
section candidate
no_agent (4.543 ms) : 4491, 4595
. : milestone, 4543,
iast (9.56 ms) : 9395, 9725
. : milestone, 9560,
iast_FULL (14.71 ms) : 14419, 15000
. : milestone, 14710,
iast_GLOBAL (11.052 ms) : 10853, 11250
. : milestone, 11052,
profiling (9.445 ms) : 9288, 9602
. : milestone, 9445,
tracing (7.719 ms) : 7609, 7829
. : milestone, 7719,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (36.378 ms) : 36097, 36659
. : milestone, 36378,
appsec (49.258 ms) : 48822, 49694
. : milestone, 49258,
code_origins (44.879 ms) : 44490, 45268
. : milestone, 44879,
iast (43.168 ms) : 42808, 43528
. : milestone, 43168,
profiling (48.122 ms) : 47673, 48571
. : milestone, 48122,
tracing (45.469 ms) : 45075, 45862
. : milestone, 45469,
section candidate
no_agent (36.414 ms) : 36132, 36696
. : milestone, 36414,
appsec (49.861 ms) : 49422, 50300
. : milestone, 49861,
code_origins (45.074 ms) : 44680, 45468
. : milestone, 45074,
iast (46.525 ms) : 46129, 46920
. : milestone, 46525,
profiling (49.988 ms) : 49511, 50464
. : milestone, 49988,
tracing (44.562 ms) : 44176, 44948
. : milestone, 44562,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.697 ms) : 3482, 3912
. : milestone, 3697,
iast (2.214 ms) : 2151, 2277
. : milestone, 2214,
iast_GLOBAL (2.25 ms) : 2187, 2314
. : milestone, 2250,
profiling (2.049 ms) : 1999, 2100
. : milestone, 2049,
tracing (2.019 ms) : 1971, 2068
. : milestone, 2019,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.631 ms) : 3419, 3844
. : milestone, 3631,
iast (2.206 ms) : 2143, 2270
. : milestone, 2206,
iast_GLOBAL (2.249 ms) : 2185, 2312
. : milestone, 2249,
profiling (2.074 ms) : 2022, 2126
. : milestone, 2074,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~6b5709a70e, baseline=1.54.0-SNAPSHOT~050cad8b0e
dateFormat X
axisFormat %s
section baseline
no_agent (15.361 s) : 15361000, 15361000
. : milestone, 15361000,
appsec (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
iast (18.542 s) : 18542000, 18542000
. : milestone, 18542000,
iast_GLOBAL (17.697 s) : 17697000, 17697000
. : milestone, 17697000,
profiling (15.863 s) : 15863000, 15863000
. : milestone, 15863000,
tracing (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
section candidate
no_agent (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
appsec (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
iast (18.432 s) : 18432000, 18432000
. : milestone, 18432000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
profiling (15.87 s) : 15870000, 15870000
. : milestone, 15870000,
tracing (15.335 s) : 15335000, 15335000
. : milestone, 15335000,
|
|
||
forbiddenApisMain { | ||
tasks.named("forbiddenApisMain") { | ||
failOnMissingClasses = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't able to add the ForbiddenApisTask
class because the Groovy compiler fails to recognize / load this class until after the de.thetaphi.forbiddenapis.gradle.ForbiddenApisTask
plugin is applied... but it hasn't been loaded? Let me know if there's a better way to do this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, maybe use import
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried import
and still got the error of unable to resolve class...
from the import
line 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep as is. This ForbiddenApisTask
kind of problematic to me. It is not working well with Java 21+ for example. We may think how to replace it all together, maybe with fork or internal tool. Like @bric3 recently did for version plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure yet. But the issue with forbidden task is tricky with script plug-ins, there are different classloaders for script plugins. And probably require a proper declaration in the plugins {}
block. This should be solved with convention plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sounds good.
What Does This Do
Update smoke test gradle file tasks to use lazy API formatting
Motivation
Build improvements
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]