-
Notifications
You must be signed in to change notification settings - Fork 312
wildfly-9.0 configuration was eager and misplaced #9624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The copy task was using the build directory as output which made all tasks depend on it.
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: 5a6dc7a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1011700
Total [baseline] (10.76 s) : 0, 10760240
Agent [candidate] (1.01 s) : 0, 1010042
Total [candidate] (10.621 s) : 0, 10620921
section appsec
Agent [baseline] (1.199 s) : 0, 1198787
Total [baseline] (10.976 s) : 0, 10975806
Agent [candidate] (1.185 s) : 0, 1184900
Total [candidate] (11.046 s) : 0, 11045896
section iast
Agent [baseline] (1.146 s) : 0, 1145540
Total [baseline] (10.98 s) : 0, 10980161
Agent [candidate] (1.161 s) : 0, 1161064
Total [candidate] (11.04 s) : 0, 11039968
section profiling
Agent [baseline] (1.156 s) : 0, 1156301
Total [baseline] (11.028 s) : 0, 11027708
Agent [candidate] (1.152 s) : 0, 1152051
Total [candidate] (11.017 s) : 0, 11016564
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (689.044 ms) : 0, 689044
BytebuddyAgent [candidate] (688.1 ms) : 0, 688100
GlobalTracer [baseline] (242.888 ms) : 0, 242888
GlobalTracer [candidate] (242.582 ms) : 0, 242582
AppSec [baseline] (31.132 ms) : 0, 31132
AppSec [candidate] (31.32 ms) : 0, 31320
Debugger [baseline] (6.338 ms) : 0, 6338
Debugger [candidate] (6.284 ms) : 0, 6284
Remote Config [baseline] (671.4 µs) : 0, 671
Remote Config [candidate] (669.315 µs) : 0, 669
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (9.044 ms) : 0, 9044
Flare Poller [baseline] (9.969 ms) : 0, 9969
Flare Poller [candidate] (9.466 ms) : 0, 9466
section appsec
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (719.836 ms) : 0, 719836
BytebuddyAgent [candidate] (711.513 ms) : 0, 711513
GlobalTracer [baseline] (237.319 ms) : 0, 237319
GlobalTracer [candidate] (234.716 ms) : 0, 234716
AppSec [baseline] (172.956 ms) : 0, 172956
AppSec [candidate] (172.35 ms) : 0, 172350
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (635.938 µs) : 0, 636
Remote Config [candidate] (615.848 µs) : 0, 616
Telemetry [baseline] (8.321 ms) : 0, 8321
Telemetry [candidate] (8.288 ms) : 0, 8288
Flare Poller [baseline] (5.705 ms) : 0, 5705
Flare Poller [candidate] (4.058 ms) : 0, 4058
IAST [baseline] (25.238 ms) : 0, 25238
IAST [candidate] (24.846 ms) : 0, 24846
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (810.028 ms) : 0, 810028
BytebuddyAgent [candidate] (822.539 ms) : 0, 822539
GlobalTracer [baseline] (233.099 ms) : 0, 233099
GlobalTracer [candidate] (235.032 ms) : 0, 235032
AppSec [baseline] (34.097 ms) : 0, 34097
AppSec [candidate] (34.291 ms) : 0, 34291
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.122 ms) : 0, 6122
Remote Config [baseline] (597.283 µs) : 0, 597
Remote Config [candidate] (587.125 µs) : 0, 587
Telemetry [baseline] (8.135 ms) : 0, 8135
Telemetry [candidate] (8.214 ms) : 0, 8214
Flare Poller [baseline] (4.288 ms) : 0, 4288
Flare Poller [candidate] (4.261 ms) : 0, 4261
IAST [baseline] (26.468 ms) : 0, 26468
IAST [candidate] (27.091 ms) : 0, 27091
section profiling
ProfilingAgent [baseline] (102.176 ms) : 0, 102176
ProfilingAgent [candidate] (101.83 ms) : 0, 101830
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (720.879 ms) : 0, 720879
BytebuddyAgent [candidate] (718.795 ms) : 0, 718795
GlobalTracer [baseline] (219.753 ms) : 0, 219753
GlobalTracer [candidate] (218.795 ms) : 0, 218795
AppSec [baseline] (31.684 ms) : 0, 31684
AppSec [candidate] (31.23 ms) : 0, 31230
Debugger [baseline] (7.275 ms) : 0, 7275
Debugger [candidate] (6.466 ms) : 0, 6466
Remote Config [baseline] (736.407 µs) : 0, 736
Remote Config [candidate] (709.787 µs) : 0, 710
Telemetry [baseline] (15.7 ms) : 0, 15700
Telemetry [candidate] (16.31 ms) : 0, 16310
Flare Poller [baseline] (4.203 ms) : 0, 4203
Flare Poller [candidate] (4.16 ms) : 0, 4160
Profiling [baseline] (102.767 ms) : 0, 102767
Profiling [candidate] (102.409 ms) : 0, 102409
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016368
Total [baseline] (8.655 s) : 0, 8655472
Agent [candidate] (1.019 s) : 0, 1019175
Total [candidate] (8.67 s) : 0, 8669548
section iast
Agent [baseline] (1.147 s) : 0, 1146592
Total [baseline] (9.286 s) : 0, 9285892
Agent [candidate] (1.151 s) : 0, 1150796
Total [candidate] (9.237 s) : 0, 9237173
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (690.688 ms) : 0, 690688
BytebuddyAgent [candidate] (692.981 ms) : 0, 692981
GlobalTracer [baseline] (244.339 ms) : 0, 244339
GlobalTracer [candidate] (244.135 ms) : 0, 244135
AppSec [baseline] (31.77 ms) : 0, 31770
AppSec [candidate] (31.455 ms) : 0, 31455
Debugger [baseline] (6.416 ms) : 0, 6416
Debugger [candidate] (6.375 ms) : 0, 6375
Remote Config [baseline] (711.871 µs) : 0, 712
Remote Config [candidate] (679.952 µs) : 0, 680
Telemetry [baseline] (9.162 ms) : 0, 9162
Telemetry [candidate] (9.082 ms) : 0, 9082
Flare Poller [baseline] (10.718 ms) : 0, 10718
Flare Poller [candidate] (11.79 ms) : 0, 11790
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (811.4 ms) : 0, 811400
BytebuddyAgent [candidate] (814.141 ms) : 0, 814141
GlobalTracer [baseline] (232.836 ms) : 0, 232836
GlobalTracer [candidate] (233.997 ms) : 0, 233997
IAST [baseline] (26.502 ms) : 0, 26502
IAST [candidate] (26.513 ms) : 0, 26513
AppSec [baseline] (33.89 ms) : 0, 33890
AppSec [candidate] (34.229 ms) : 0, 34229
Debugger [baseline] (6.063 ms) : 0, 6063
Debugger [candidate] (6.084 ms) : 0, 6084
Remote Config [baseline] (603.956 µs) : 0, 604
Remote Config [candidate] (585.187 µs) : 0, 585
Telemetry [baseline] (8.158 ms) : 0, 8158
Telemetry [candidate] (8.175 ms) : 0, 8175
Flare Poller [baseline] (4.336 ms) : 0, 4336
Flare Poller [candidate] (4.305 ms) : 0, 4305
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (4.439 ms) : 4382, 4497
. : milestone, 4439,
iast (9.9 ms) : 9731, 10069
. : milestone, 9900,
iast_FULL (14.054 ms) : 13774, 14334
. : milestone, 14054,
iast_GLOBAL (11.361 ms) : 11154, 11567
. : milestone, 11361,
profiling (8.795 ms) : 8658, 8931
. : milestone, 8795,
tracing (8.02 ms) : 7902, 8138
. : milestone, 8020,
section candidate
no_agent (4.31 ms) : 4262, 4359
. : milestone, 4310,
iast (10.343 ms) : 10166, 10520
. : milestone, 10343,
iast_FULL (14.13 ms) : 13852, 14409
. : milestone, 14130,
iast_GLOBAL (10.163 ms) : 9979, 10346
. : milestone, 10163,
profiling (9.23 ms) : 9084, 9377
. : milestone, 9230,
tracing (7.891 ms) : 7774, 8008
. : milestone, 7891,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (37.133 ms) : 36835, 37432
. : milestone, 37133,
appsec (49.083 ms) : 48650, 49517
. : milestone, 49083,
code_origins (44.75 ms) : 44360, 45140
. : milestone, 44750,
iast (45.242 ms) : 44856, 45627
. : milestone, 45242,
profiling (48.918 ms) : 48435, 49400
. : milestone, 48918,
tracing (44.762 ms) : 44379, 45145
. : milestone, 44762,
section candidate
no_agent (37.57 ms) : 37266, 37874
. : milestone, 37570,
appsec (49.896 ms) : 49460, 50332
. : milestone, 49896,
code_origins (43.062 ms) : 42686, 43438
. : milestone, 43062,
iast (45.731 ms) : 45328, 46135
. : milestone, 45731,
profiling (50.45 ms) : 49941, 50959
. : milestone, 50450,
tracing (46.401 ms) : 46001, 46802
. : milestone, 46401,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.733 ms) : 3515, 3950
. : milestone, 3733,
iast (2.213 ms) : 2150, 2276
. : milestone, 2213,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.053 ms) : 2001, 2104
. : milestone, 2053,
tracing (2.006 ms) : 1958, 2054
. : milestone, 2006,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.519 ms) : 2466, 2572
. : milestone, 2519,
iast (2.206 ms) : 2144, 2269
. : milestone, 2206,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.058 ms) : 2006, 2109
. : milestone, 2058,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a6dc7aac6, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
appsec (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
iast (18.518 s) : 18518000, 18518000
. : milestone, 18518000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.703 s) : 15703000, 15703000
. : milestone, 15703000,
tracing (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
section candidate
no_agent (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
appsec (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
iast (18.646 s) : 18646000, 18646000
. : milestone, 18646000,
iast_GLOBAL (18.14 s) : 18140000, 18140000
. : milestone, 18140000,
profiling (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
tracing (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
What Does This Do
Task declaration was misplaced in the dependencies block. And the
forkedTest
andlatestDepForkedTest
tasks had an awkward setup depending on the resolved version. Moreover, the extract tasks where using thebuildDir
as destination which overlapped with every other tasks input in this project.Now the tasks are properly wired and extracted in proper subfolders.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]