-
Notifications
You must be signed in to change notification settings - Fork 312
Method includeShadowJar
was breaking shadowJar
tasks laziness
#9626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.543 µs) : 288, 352
. : milestone, 320,
basic (282.316 µs) : 275, 289
. : milestone, 282,
loop (8.964 ms) : 8959, 8969
. : milestone, 8964,
section candidate
noprobe (336.28 µs) : 276, 396
. : milestone, 336,
basic (281.033 µs) : 274, 288
. : milestone, 281,
loop (8.961 ms) : 8956, 8967
. : milestone, 8961,
|
🎯 Code Coverage 🔗 Commit SHA: b03a271 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1011015
Total [baseline] (10.608 s) : 0, 10607917
Agent [candidate] (1.011 s) : 0, 1011454
Total [candidate] (10.659 s) : 0, 10658586
section appsec
Agent [baseline] (1.195 s) : 0, 1195278
Total [baseline] (11.142 s) : 0, 11142107
Agent [candidate] (1.193 s) : 0, 1193278
Total [candidate] (11.017 s) : 0, 11017435
section iast
Agent [baseline] (1.152 s) : 0, 1151919
Total [baseline] (10.961 s) : 0, 10960569
Agent [candidate] (1.154 s) : 0, 1153934
Total [candidate] (10.942 s) : 0, 10942401
section profiling
Agent [baseline] (1.151 s) : 0, 1151284
Total [baseline] (11.012 s) : 0, 11011635
Agent [candidate] (1.155 s) : 0, 1154733
Total [candidate] (11.176 s) : 0, 11175575
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (687.714 ms) : 0, 687714
BytebuddyAgent [candidate] (687.816 ms) : 0, 687816
GlobalTracer [baseline] (242.761 ms) : 0, 242761
GlobalTracer [candidate] (242.879 ms) : 0, 242879
AppSec [baseline] (31.272 ms) : 0, 31272
AppSec [candidate] (31.36 ms) : 0, 31360
Debugger [baseline] (6.319 ms) : 0, 6319
Debugger [candidate] (6.357 ms) : 0, 6357
Remote Config [baseline] (664.104 µs) : 0, 664
Remote Config [candidate] (675.491 µs) : 0, 675
Telemetry [baseline] (9.098 ms) : 0, 9098
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (10.556 ms) : 0, 10556
Flare Poller [candidate] (10.858 ms) : 0, 10858
section appsec
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (717.398 ms) : 0, 717398
BytebuddyAgent [candidate] (716.371 ms) : 0, 716371
GlobalTracer [baseline] (236.868 ms) : 0, 236868
GlobalTracer [candidate] (236.659 ms) : 0, 236659
AppSec [baseline] (173.216 ms) : 0, 173216
AppSec [candidate] (170.99 ms) : 0, 170990
Debugger [baseline] (6.075 ms) : 0, 6075
Debugger [candidate] (6.823 ms) : 0, 6823
Remote Config [baseline] (632.107 µs) : 0, 632
Remote Config [candidate] (622.285 µs) : 0, 622
Telemetry [baseline] (8.478 ms) : 0, 8478
Telemetry [candidate] (8.371 ms) : 0, 8371
Flare Poller [baseline] (4.823 ms) : 0, 4823
Flare Poller [candidate] (5.551 ms) : 0, 5551
IAST [baseline] (25.076 ms) : 0, 25076
IAST [candidate] (25.19 ms) : 0, 25190
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (815.229 ms) : 0, 815229
BytebuddyAgent [candidate] (816.365 ms) : 0, 816365
GlobalTracer [baseline] (234.059 ms) : 0, 234059
GlobalTracer [candidate] (234.35 ms) : 0, 234350
AppSec [baseline] (33.803 ms) : 0, 33803
AppSec [candidate] (34.316 ms) : 0, 34316
Debugger [baseline] (6.117 ms) : 0, 6117
Debugger [candidate] (6.067 ms) : 0, 6067
Remote Config [baseline] (600.844 µs) : 0, 601
Remote Config [candidate] (587.174 µs) : 0, 587
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (8.28 ms) : 0, 8280
Flare Poller [baseline] (4.247 ms) : 0, 4247
Flare Poller [candidate] (4.304 ms) : 0, 4304
IAST [baseline] (26.589 ms) : 0, 26589
IAST [candidate] (26.7 ms) : 0, 26700
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (718.328 ms) : 0, 718328
BytebuddyAgent [candidate] (720.172 ms) : 0, 720172
GlobalTracer [baseline] (218.819 ms) : 0, 218819
GlobalTracer [candidate] (219.395 ms) : 0, 219395
AppSec [baseline] (31.424 ms) : 0, 31424
AppSec [candidate] (31.779 ms) : 0, 31779
Debugger [baseline] (6.471 ms) : 0, 6471
Debugger [candidate] (6.567 ms) : 0, 6567
Remote Config [baseline] (719.155 µs) : 0, 719
Remote Config [candidate] (1.463 ms) : 0, 1463
Telemetry [baseline] (16.202 ms) : 0, 16202
Telemetry [candidate] (15.834 ms) : 0, 15834
Flare Poller [baseline] (4.207 ms) : 0, 4207
Flare Poller [candidate] (4.194 ms) : 0, 4194
ProfilingAgent [baseline] (100.714 ms) : 0, 100714
ProfilingAgent [candidate] (101.551 ms) : 0, 101551
Profiling [baseline] (101.924 ms) : 0, 101924
Profiling [candidate] (102.137 ms) : 0, 102137
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1011960
Total [baseline] (8.63 s) : 0, 8629910
Agent [candidate] (1.022 s) : 0, 1021608
Total [candidate] (8.65 s) : 0, 8649607
section iast
Agent [baseline] (1.145 s) : 0, 1144682
Total [baseline] (9.248 s) : 0, 9248337
Agent [candidate] (1.145 s) : 0, 1145500
Total [candidate] (9.261 s) : 0, 9260912
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (688.048 ms) : 0, 688048
BytebuddyAgent [candidate] (695.255 ms) : 0, 695255
GlobalTracer [baseline] (242.827 ms) : 0, 242827
GlobalTracer [candidate] (244.763 ms) : 0, 244763
AppSec [baseline] (31.435 ms) : 0, 31435
AppSec [candidate] (31.536 ms) : 0, 31536
Debugger [baseline] (6.313 ms) : 0, 6313
Debugger [candidate] (6.421 ms) : 0, 6421
Remote Config [baseline] (675.672 µs) : 0, 676
Remote Config [candidate] (676.567 µs) : 0, 677
Telemetry [baseline] (9.064 ms) : 0, 9064
Telemetry [candidate] (9.174 ms) : 0, 9174
Flare Poller [baseline] (10.926 ms) : 0, 10926
Flare Poller [candidate] (11.1 ms) : 0, 11100
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (809.882 ms) : 0, 809882
BytebuddyAgent [candidate] (810.401 ms) : 0, 810401
GlobalTracer [baseline] (232.488 ms) : 0, 232488
GlobalTracer [candidate] (232.717 ms) : 0, 232717
AppSec [baseline] (34.143 ms) : 0, 34143
AppSec [candidate] (34.105 ms) : 0, 34105
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.058 ms) : 0, 6058
Remote Config [baseline] (590.669 µs) : 0, 591
Remote Config [candidate] (579.922 µs) : 0, 580
Telemetry [baseline] (8.032 ms) : 0, 8032
Telemetry [candidate] (8.177 ms) : 0, 8177
Flare Poller [baseline] (4.288 ms) : 0, 4288
Flare Poller [candidate] (4.316 ms) : 0, 4316
IAST [baseline] (26.456 ms) : 0, 26456
IAST [candidate] (26.498 ms) : 0, 26498
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (37.297 ms) : 36992, 37602
. : milestone, 37297,
appsec (49.023 ms) : 48580, 49466
. : milestone, 49023,
code_origins (44.699 ms) : 44312, 45086
. : milestone, 44699,
iast (45.333 ms) : 44947, 45719
. : milestone, 45333,
profiling (50.463 ms) : 50007, 50919
. : milestone, 50463,
tracing (43.468 ms) : 43097, 43839
. : milestone, 43468,
section candidate
no_agent (38.395 ms) : 38082, 38708
. : milestone, 38395,
appsec (49.046 ms) : 48612, 49480
. : milestone, 49046,
code_origins (43.678 ms) : 43309, 44047
. : milestone, 43678,
iast (44.714 ms) : 44332, 45097
. : milestone, 44714,
profiling (47.806 ms) : 47377, 48234
. : milestone, 47806,
tracing (45.677 ms) : 45290, 46063
. : milestone, 45677,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (4.2 ms) : 4150, 4250
. : milestone, 4200,
iast (9.436 ms) : 9283, 9588
. : milestone, 9436,
iast_FULL (13.753 ms) : 13484, 14022
. : milestone, 13753,
iast_GLOBAL (10.38 ms) : 10198, 10563
. : milestone, 10380,
profiling (9.266 ms) : 9120, 9412
. : milestone, 9266,
tracing (7.758 ms) : 7646, 7870
. : milestone, 7758,
section candidate
no_agent (4.392 ms) : 4343, 4440
. : milestone, 4392,
iast (9.674 ms) : 9515, 9833
. : milestone, 9674,
iast_FULL (13.659 ms) : 13383, 13935
. : milestone, 13659,
iast_GLOBAL (10.463 ms) : 10274, 10652
. : milestone, 10463,
profiling (9.182 ms) : 9038, 9326
. : milestone, 9182,
tracing (8.102 ms) : 7980, 8225
. : milestone, 8102,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.682 ms) : 3462, 3903
. : milestone, 3682,
iast (2.186 ms) : 2123, 2249
. : milestone, 2186,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.056 ms) : 2005, 2108
. : milestone, 2056,
tracing (2.016 ms) : 1967, 2064
. : milestone, 2016,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.712 ms) : 3491, 3932
. : milestone, 3712,
iast (2.188 ms) : 2126, 2251
. : milestone, 2188,
iast_GLOBAL (2.233 ms) : 2171, 2296
. : milestone, 2233,
profiling (2.053 ms) : 2001, 2105
. : milestone, 2053,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b03a271f51, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
iast (18.412 s) : 18412000, 18412000
. : milestone, 18412000,
iast_GLOBAL (18.116 s) : 18116000, 18116000
. : milestone, 18116000,
profiling (15.915 s) : 15915000, 15915000
. : milestone, 15915000,
tracing (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
section candidate
no_agent (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
appsec (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
iast (18.858 s) : 18858000, 18858000
. : milestone, 18858000,
iast_GLOBAL (17.601 s) : 17601000, 17601000
. : milestone, 17601000,
profiling (15.179 s) : 15179000, 15179000
. : milestone, 15179000,
tracing (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thanks for the improvement 👍
What Does This Do
It replaces the
.get().archiveFile
on theshadowJarTask
to include by a mapping operationshadowJarTask.map { it.archiveFile }
that preserves laziness.Moved eager
shadowJar
task groovy accessor to lazytasks.named(...)
Motivation
Reduce configuration time
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]