-
Notifications
You must be signed in to change notification settings - Fork 312
Refactor multiple instrumentation module #9629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012082
Total [baseline] (10.622 s) : 0, 10621540
Agent [candidate] (1.021 s) : 0, 1021111
Total [candidate] (10.683 s) : 0, 10683034
section appsec
Agent [baseline] (1.189 s) : 0, 1189165
Total [baseline] (11.056 s) : 0, 11055609
Agent [candidate] (1.19 s) : 0, 1190411
Total [candidate] (11.124 s) : 0, 11123628
section iast
Agent [baseline] (1.155 s) : 0, 1155449
Total [baseline] (11.009 s) : 0, 11009442
Agent [candidate] (1.145 s) : 0, 1144682
Total [candidate] (10.914 s) : 0, 10913861
section profiling
Agent [baseline] (1.159 s) : 0, 1158580
Total [baseline] (11.125 s) : 0, 11124588
Agent [candidate] (1.158 s) : 0, 1157909
Total [candidate] (11.063 s) : 0, 11063301
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (689.046 ms) : 0, 689046
BytebuddyAgent [candidate] (695.14 ms) : 0, 695140
GlobalTracer [baseline] (242.923 ms) : 0, 242923
GlobalTracer [candidate] (244.522 ms) : 0, 244522
AppSec [baseline] (31.436 ms) : 0, 31436
AppSec [candidate] (31.517 ms) : 0, 31517
Debugger [baseline] (6.328 ms) : 0, 6328
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (666.745 µs) : 0, 667
Remote Config [candidate] (692.444 µs) : 0, 692
Telemetry [baseline] (9.022 ms) : 0, 9022
Telemetry [candidate] (9.165 ms) : 0, 9165
Flare Poller [baseline] (9.998 ms) : 0, 9998
Flare Poller [candidate] (10.859 ms) : 0, 10859
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (714.113 ms) : 0, 714113
BytebuddyAgent [candidate] (715.889 ms) : 0, 715889
GlobalTracer [baseline] (235.479 ms) : 0, 235479
GlobalTracer [candidate] (235.108 ms) : 0, 235108
IAST [baseline] (24.852 ms) : 0, 24852
IAST [candidate] (24.835 ms) : 0, 24835
AppSec [baseline] (172.098 ms) : 0, 172098
AppSec [candidate] (171.294 ms) : 0, 171294
Debugger [baseline] (6.055 ms) : 0, 6055
Debugger [candidate] (6.836 ms) : 0, 6836
Remote Config [baseline] (636.632 µs) : 0, 637
Remote Config [candidate] (628.822 µs) : 0, 629
Telemetry [baseline] (8.35 ms) : 0, 8350
Telemetry [candidate] (9.201 ms) : 0, 9201
Flare Poller [baseline] (4.858 ms) : 0, 4858
Flare Poller [candidate] (3.954 ms) : 0, 3954
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (817.012 ms) : 0, 817012
BytebuddyAgent [candidate] (809.815 ms) : 0, 809815
GlobalTracer [baseline] (234.845 ms) : 0, 234845
GlobalTracer [candidate] (232.803 ms) : 0, 232803
IAST [baseline] (26.85 ms) : 0, 26850
IAST [candidate] (26.267 ms) : 0, 26267
AppSec [baseline] (34.297 ms) : 0, 34297
AppSec [candidate] (33.761 ms) : 0, 33761
Debugger [baseline] (6.161 ms) : 0, 6161
Debugger [candidate] (6.012 ms) : 0, 6012
Remote Config [baseline] (606.562 µs) : 0, 607
Remote Config [candidate] (585.998 µs) : 0, 586
Telemetry [baseline] (8.285 ms) : 0, 8285
Telemetry [candidate] (8.178 ms) : 0, 8178
Flare Poller [baseline] (4.37 ms) : 0, 4370
Flare Poller [candidate] (4.265 ms) : 0, 4265
section profiling
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (722.164 ms) : 0, 722164
BytebuddyAgent [candidate] (724.765 ms) : 0, 724765
GlobalTracer [baseline] (220.862 ms) : 0, 220862
GlobalTracer [candidate] (218.487 ms) : 0, 218487
AppSec [baseline] (31.942 ms) : 0, 31942
AppSec [candidate] (31.545 ms) : 0, 31545
Debugger [baseline] (7.312 ms) : 0, 7312
Debugger [candidate] (6.561 ms) : 0, 6561
Remote Config [baseline] (734.514 µs) : 0, 735
Remote Config [candidate] (733.789 µs) : 0, 734
Telemetry [baseline] (15.426 ms) : 0, 15426
Telemetry [candidate] (16.34 ms) : 0, 16340
Flare Poller [baseline] (4.202 ms) : 0, 4202
Flare Poller [candidate] (4.195 ms) : 0, 4195
ProfilingAgent [baseline] (101.855 ms) : 0, 101855
ProfilingAgent [candidate] (101.207 ms) : 0, 101207
Profiling [baseline] (102.449 ms) : 0, 102449
Profiling [candidate] (101.797 ms) : 0, 101797
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015784
Total [baseline] (8.67 s) : 0, 8670451
Agent [candidate] (1.014 s) : 0, 1013577
Total [candidate] (8.652 s) : 0, 8651757
section iast
Agent [baseline] (1.161 s) : 0, 1161185
Total [baseline] (9.266 s) : 0, 9265966
Agent [candidate] (1.147 s) : 0, 1146773
Total [candidate] (9.296 s) : 0, 9296371
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (691.138 ms) : 0, 691138
BytebuddyAgent [candidate] (688.76 ms) : 0, 688760
GlobalTracer [baseline] (243.432 ms) : 0, 243432
GlobalTracer [candidate] (243.279 ms) : 0, 243279
AppSec [baseline] (31.407 ms) : 0, 31407
AppSec [candidate] (31.478 ms) : 0, 31478
Debugger [baseline] (6.358 ms) : 0, 6358
Debugger [candidate] (6.395 ms) : 0, 6395
Remote Config [baseline] (672.156 µs) : 0, 672
Remote Config [candidate] (681.957 µs) : 0, 682
Telemetry [baseline] (9.101 ms) : 0, 9101
Telemetry [candidate] (9.036 ms) : 0, 9036
Flare Poller [baseline] (11.031 ms) : 0, 11031
Flare Poller [candidate] (11.413 ms) : 0, 11413
section iast
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (822.387 ms) : 0, 822387
BytebuddyAgent [candidate] (812.318 ms) : 0, 812318
GlobalTracer [baseline] (235.145 ms) : 0, 235145
GlobalTracer [candidate] (232.378 ms) : 0, 232378
IAST [baseline] (26.906 ms) : 0, 26906
IAST [candidate] (26.221 ms) : 0, 26221
AppSec [baseline] (34.401 ms) : 0, 34401
AppSec [candidate] (33.965 ms) : 0, 33965
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (5.994 ms) : 0, 5994
Remote Config [baseline] (597.655 µs) : 0, 598
Remote Config [candidate] (586.887 µs) : 0, 587
Telemetry [baseline] (8.273 ms) : 0, 8273
Telemetry [candidate] (8.066 ms) : 0, 8066
Flare Poller [baseline] (4.288 ms) : 0, 4288
Flare Poller [candidate] (4.251 ms) : 0, 4251
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section baseline
no_agent (4.36 ms) : 4307, 4413
. : milestone, 4360,
iast (10.061 ms) : 9889, 10233
. : milestone, 10061,
iast_FULL (15.412 ms) : 15096, 15728
. : milestone, 15412,
iast_GLOBAL (10.364 ms) : 10182, 10545
. : milestone, 10364,
profiling (9.225 ms) : 9069, 9380
. : milestone, 9225,
tracing (7.881 ms) : 7769, 7992
. : milestone, 7881,
section candidate
no_agent (4.428 ms) : 4378, 4478
. : milestone, 4428,
iast (9.933 ms) : 9761, 10105
. : milestone, 9933,
iast_FULL (13.99 ms) : 13710, 14271
. : milestone, 13990,
iast_GLOBAL (9.914 ms) : 9727, 10100
. : milestone, 9914,
profiling (9.397 ms) : 9239, 9554
. : milestone, 9397,
tracing (7.623 ms) : 7518, 7728
. : milestone, 7623,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section baseline
no_agent (35.996 ms) : 35706, 36287
. : milestone, 35996,
appsec (50.686 ms) : 50239, 51133
. : milestone, 50686,
code_origins (43.597 ms) : 43223, 43970
. : milestone, 43597,
iast (45.46 ms) : 45071, 45848
. : milestone, 45460,
profiling (50.502 ms) : 49987, 51017
. : milestone, 50502,
tracing (45.65 ms) : 45252, 46049
. : milestone, 45650,
section candidate
no_agent (37.802 ms) : 37501, 38102
. : milestone, 37802,
appsec (48.688 ms) : 48270, 49105
. : milestone, 48688,
code_origins (44.576 ms) : 44183, 44968
. : milestone, 44576,
iast (46.162 ms) : 45758, 46566
. : milestone, 46162,
profiling (49.043 ms) : 48585, 49502
. : milestone, 49043,
tracing (45.286 ms) : 44893, 45679
. : milestone, 45286,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section baseline
no_agent (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
appsec (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
iast (18.75 s) : 18750000, 18750000
. : milestone, 18750000,
iast_GLOBAL (17.901 s) : 17901000, 17901000
. : milestone, 17901000,
profiling (15.455 s) : 15455000, 15455000
. : milestone, 15455000,
tracing (15.312 s) : 15312000, 15312000
. : milestone, 15312000,
section candidate
no_agent (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
appsec (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
iast (18.589 s) : 18589000, 18589000
. : milestone, 18589000,
iast_GLOBAL (18.152 s) : 18152000, 18152000
. : milestone, 18152000,
profiling (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
tracing (15.096 s) : 15096000, 15096000
. : milestone, 15096000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4596c1189d, baseline=1.54.0-SNAPSHOT~9449786520
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1482
. : milestone, 1471,
appsec (3.694 ms) : 3476, 3912
. : milestone, 3694,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.057 ms) : 2005, 2109
. : milestone, 2057,
tracing (2.013 ms) : 1965, 2062
. : milestone, 2013,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.657 ms) : 3447, 3868
. : milestone, 3657,
iast (2.197 ms) : 2134, 2260
. : milestone, 2197,
iast_GLOBAL (2.233 ms) : 2170, 2296
. : milestone, 2233,
profiling (2.032 ms) : 1982, 2082
. : milestone, 2032,
tracing (2.019 ms) : 1970, 2068
. : milestone, 2019,
|
🎯 Code Coverage 🔗 Commit SHA: 4596c11 | Docs | Was this helpful? Give us feedback! |
67d0db5
to
171bec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Thanks for the clean up 🧹
What Does This Do
Refactor multiple instrumentation module according to new layout conventions
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]