Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Perhardhernandez/no default special case #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Perhardhernandez/no default special case #6430

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
aa0a34a
remove special-casing of default in hook.js, update http2 integration
bengl Aug 20, 2025
f585a35
Added net integration tests for different import
perhardhernandez Sep 8, 2025
8315da0
fix bunyan for new esm import handling
bengl Sep 9, 2025
2292d3b
add a variants helper for esm tests
bengl Sep 9, 2025
3d25ea1
Added import variation tests for elasticsearch
perhardhernandez Sep 9, 2025
3de006d
Added import variations tests for amqplib
perhardhernandez Sep 9, 2025
f7dc238
more correct approach for dealing with default exports
bengl Sep 10, 2025
eb3a11a
update bunyan, fastify, http2, and pino for new default handling
bengl Sep 10, 2025
4674f3d
Added import variation tests for cassandra-driver
perhardhernandez Sep 10, 2025
2d6124d
Added import variation tests for connect
perhardhernandez Sep 11, 2025
e7d7205
Refactor hook.js to use WeakMap for patched exports, improving handli…
perhardhernandez Sep 11, 2025
2ed771e
update ioredis for new default handling, and vary import tests
bengl Sep 12, 2025
d9ab3c5
Added import variations tests for express
perhardhernandez Sep 12, 2025
ef127a9
removing express changes (express will fail)
perhardhernandez Sep 12, 2025
556ae2f
express tests back to original state
perhardhernandez Sep 12, 2025
ac6a4a7
readed express changes
perhardhernandez Sep 12, 2025
30bc2d4
express back to original state
perhardhernandez Sep 12, 2025
95780dd
added random coment
perhardhernandez Sep 12, 2025
2348e99
added small change
perhardhernandez Sep 12, 2025
ab1710b
Added file property for version 4
perhardhernandez Sep 12, 2025
0a599db
Adding file property for version 5.0.0
perhardhernandez Sep 12, 2025
5328b82
removed file for version 5.0.0
perhardhernandez Sep 12, 2025
0082d63
Added back file property for version 4
perhardhernandez Sep 12, 2025
5f7a876
Merge branch 'master' into perhardhernandez/no-default-special-case
perhardhernandez Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
express back to original state
  • Loading branch information
@perhardhernandez
perhardhernandez committed Sep 12, 2025
commit 30bc2d44a147637cc42456275c85d6df32ed6019
10 changes: 5 additions & 5 deletions packages/datadog-instrumentations/src/express.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function wrapResponseRender (render) {
}
}

addHook({ name: 'express', versions: ['>=4'], file: ['lib/express.js'] }, express => {
addHook({ name: 'express', versions: ['>=4'] }, express => {
shimmer.wrap(express.application, 'handle', wrapHandle)

shimmer.wrap(express.response, 'json', wrapResponseJson)
Expand All @@ -67,14 +67,14 @@ addHook({ name: 'express', versions: ['>=4'], file: ['lib/express.js'] }, expres
return express
})

addHook({ name: 'express', versions: ['4'], file: 'lib/express.js' }, express => {
addHook({ name: 'express', versions: ['4'] }, express => {
shimmer.wrap(express.Router, 'use', wrapRouterMethod)
shimmer.wrap(express.Router, 'route', wrapRouterMethod)

return express
})

addHook({ name: 'express', versions: ['>=5.0.0'], file: ['lib/express.js'] }, express => {
addHook({ name: 'express', versions: ['>=5.0.0'] }, express => {
shimmer.wrap(express.Router.prototype, 'use', wrapRouterMethod)
shimmer.wrap(express.Router.prototype, 'route', wrapRouterMethod)

Expand Down Expand Up @@ -136,12 +136,12 @@ function wrapProcessParamsMethod (requestPositionInArguments) {
}
}

addHook({ name: 'express', versions: ['>=4.0.0 <4.3.0'], file: ['lib/express.js'] }, express => {
addHook({ name: 'express', versions: ['>=4.0.0 <4.3.0'] }, express => {
shimmer.wrap(express.Router, 'process_params', wrapProcessParamsMethod(1))
return express
})

addHook({ name: 'express', versions: ['>=4.3.0 <5.0.0'], file: ['lib/express.js'] }, express => {
addHook({ name: 'express', versions: ['>=4.3.0 <5.0.0'] }, express => {
shimmer.wrap(express.Router, 'process_params', wrapProcessParamsMethod(2))
return express
})
Expand Down
Loading