[test optimization] Fix happy-dom testing issues with latest jest release
#6566
Conversation
Overall package sizeSelf size: 12.51 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.10.0 | 9.91 MB | 10.3 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.4 | 123.18 kB | 851.76 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6566 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 485 485
Lines 20337 20343 +6
=======================================
+ Hits 17063 17069 +6
Misses 3274 3274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
happy-dom testing issues with latest jest releasehappy-dom testing issues with latest jest release
BenchmarksBenchmark execution time: 2025-10-02 08:06:42 Comparing candidate commit 0dd1996 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1609 metrics, 61 unstable metrics. |
integration-tests/jest/jest.spec.js
Outdated
| slow_test_retries: { | ||
| '5s': NUM_RETRIES_EFD | ||
| // happy-dom>=19 can only be used with CJS from node 20 and above | ||
| if (NODE_MAJOR >= 20) { |
There was a problem hiding this comment.
Should we instead just skip the test for those versions? And do we not have a test matrix where older versions of happy-dom would also be tested?
There was a problem hiding this comment.
Should we instead just skip the test for those versions?
sure, I can do that
And do we not have a test matrix where older versions of happy-dom would also be tested?
not at the moment, no. We don't test the older versions for jest integration tests. This was a conscious decision back then, I think because we were content with the plugin tests testing older versions. But I want to eventually get rid of the plugin tests, so this should be revisited.
Co-authored-by: Ruben Bridgewater <[email protected]>
What does this PR do?
happy-domintegration tests for node 18.happy-domplugin tests.Motivation
happy-domreleased a breaking change for >=19: https://github.com/capricorn86/happy-dom/releases/tag/v19.0.0.Node 18 is no longer supported for CJS.
Additionally, I've removed the plugin tests for
happy-dom: these tests do not reflect the way the library is used and shouldn't have been updated in #6208. These tests should be considered legacy and should eventually be removed.