default logger arguments for compatibility with previous dd-trace-rb … #4558
+62
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
approved these changes
Apr 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4558 +/- ##
==========================================
- Coverage 97.76% 97.74% -0.03%
==========================================
Files 1404 1404
Lines 86094 86096 +2
Branches 4351 4351
==========================================
- Hits 84171 84153 -18
- Misses 1923 1943 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20815 Passed, 1371 Skipped, 3m 41.13s Total Time |
anmarchenko
approved these changes
Apr 4, 2025
TonyCTHsu
approved these changes
Apr 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…versions
What does this PR do?
Defaults logger arguments added in 2.13.0 release to
Datadog.loggerinlib/datadog/core.It also changes positional
loggerarguments to keyword ones where those arguments were added in 2.13.0, for ease of defaulting / future compatibility.Motivation:
datadog-ci-rb used the Core classes and its existing versions are not working with dd-trace-rb 2.13.0
Change log entry
Yes: default logger arguments added in dd-trace-rb 2.13.0
Additional Notes:
These defaults should not be used by dd-trace-rb itself because the tracer should always give the logger argument explicitly in all of these methods. The defaults are added for compatibility with third-party libraries or customer applications that use dd-trace-rb Core classes directly.
How to test the change?
Not tested in dd-trace-rb - should be tested manually in datadog-ci-rb