multicode examples #12945
Merged
multicode examples #12945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
299944b to
a9af197
Compare
a9af197 to
7191877
Compare
72bd9c6 to
f70c0cf
Compare
e792437 to
f7fbbd9
Compare
|
Looks great! I noticed that the tab appears sometimes randomly when there is only one example. https://docs-staging.datadoghq.com/david.jones/multicode-examples/api/latest/dashboards/#get-a-dashboard on python/others but not curl https://docs-staging.datadoghq.com/david.jones/multicode-examples/api/latest/dashboards/#delete-dashboards on curl but not others. |
f7fbbd9 to
cabd9a3
Compare
|
Thanks for the feedback, I believe that's fixed now @therve |
urseberry
approved these changes
May 4, 2022
|
Thanks David, I'm still seeing some slightly inconsistent tabs I think? It's showing on "Get a dashboard" but not "Update a dashboard" for example. Do we want to show the tab when we have a single example? |
cb7a8ad to
42e0afd
Compare
42e0afd to
094126c
Compare
|
@therve I've updated to be more consistent, let me know what you think |
bgdeutsch
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Preview
https://docs-staging.datadoghq.com/david.jones/multicode-examples/api/latest/events/#post-an-event
https://docs-staging.datadoghq.com/david.jones/multicode-examples/api/latest/logs/#aggregate-events
https://docs-staging.datadoghq.com/david.jones/multicode-examples/api/latest/synthetics/#create-an-api-test
Lots of examples
https://docs-staging.datadoghq.com/david.jones/multicode-examples/api/latest/dashboards/#create-a-new-dashboard
Additional Notes
Reviewer checklist