Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Un-single-source Flutter RUM docs #17809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 21, 2023
Merged

Un-single-source Flutter RUM docs #17809

merged 11 commits into from
Apr 21, 2023

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Apr 20, 2023 •
edited
Loading

What does this PR do?

Motivation

DOCS-5213, tied to DataDog/dd-sdk-flutter#403.

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@rtrieu rtrieu requested review from a team as code owners April 20, 2023 19:20
@rtrieu rtrieu requested a review from a team April 20, 2023 19:20
@github-actions github-actions bot added Architecture Everything related to the Doc backend Github Related to Github configurations labels Apr 20, 2023
@rtrieu rtrieu added real_user_monitoring Content changed in the real_user_monitoring folder and removed Architecture Everything related to the Doc backend Github Related to Github configurations labels Apr 20, 2023
@github-actions github-actions bot added Architecture Everything related to the Doc backend Github Related to Github configurations labels Apr 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@rtrieu rtrieu mentioned this pull request Apr 20, 2023
Merged
4 tasks
alai97
alai97 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess, looks good!

fuzzybinary
fuzzybinary approved these changes Apr 21, 2023
View reviewed changes
rtrieu
rtrieu commented Apr 21, 2023
View reviewed changes
rtrieu
rtrieu commented Apr 21, 2023
View reviewed changes
@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 21, 2023

Hi @fuzzybinary , thank you for reviewing this. I applied all your suggestions!

@rtrieu rtrieu merged commit 29812c6 into master Apr 21, 2023
@rtrieu rtrieu deleted the rtrieu/un-single-source-flutter-rum-docs branch April 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzybinary fuzzybinary fuzzybinary approved these changes

@alai97 alai97 alai97 approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Github Related to Github configurations real_user_monitoring Content changed in the real_user_monitoring folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtrieu @fuzzybinary @alai97