Update KSM documentation regarding nodes.by_condition #17823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current documentation inaccurately implies that the `kubernetes_state.node.by_condition` metric is not available in the Legacy check. This is untrue; it was introduced to the Legacy check as KSM Core was being developed. The doc change here makes this distinction a bit more clear.
estherk15
requested changes
Apr 21, 2023
Co-authored-by: Esther Kim <[email protected]>
estherk15
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation inaccurately implies that the
kubernetes_state.node.by_conditionmetric is not available in the Legacy check. This is untrue; it was introduced to the Legacy check as KSM Core was being developed. The doc change here makes this distinction a bit more clear.What does this PR do?
Motivation
This escalation
noted the existance of the
node.by_conditionmetric in Legacy KSM.Additional Notes
Reviewer checklist