Fix Java tracer library context propagation #17915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
hestonhoffman
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
LGTM! Not sure if you need a review from @bantonsson before I merge, but ping me when you're ready for merge and I'll 
|
He was the one in charge of the feature. I want to be sure the fix is right before landing into customers hands. |
bantonsson
approved these changes
Apr 28, 2023
|
@hestonhoffman Feel free to merge! |
|
@kayayarai I think that the changes in #17518 might have reintroduced these deprecated settings into the docs for more languages than Java. |
|
I had the same feeling but I was not sure if the settings was unified for all languages or not. |
|
Ok, I'll check. Thanks for raising this |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the Java tracer library context propagation documentation to use the latest settings available.
Motivation
DD_PROPAGATION_STYLE_INJECTandDD_PROPAGATION_STYLE_EXTRACTare the old and now deprecated settings.Moreover, they do not support all the propagation styles listed in the documentation page (
tracecontextis missing) so this lead to confusion for customers.Additional Notes
Reviewer checklist