Tracing: Update Ruby trace_id generation range #19521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had the trace id for Ruby being an integer from 1 to (2**62)-1 for quite some time: https://github.com/DataDog/dd-trace-rb/blob/09c08622ea7f7ca4e193ea6bca6daec4cde3e8cb/lib/datadog/tracing/utils.rb#L13-L20 This PR updates this documentation page to reflect that range.
marcotc
commented
Aug 25, 2023
Comment on lines
21
to
22
| | C++ | Unsigned [0, $2^63-1$] | Unsigned | No newline at end of file | ||
| | C++ | Unsigned [0, $2^63-1$] | Unsigned | |
There was a problem hiding this comment.
Trailing new line, introduced by the GitHub editor I think
Preview links (active after the
|
cswatt
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the trace id generation page with the correct rage for the Ruby tracer.
Motivation
We've had the trace id for Ruby being an integer from 1 to (2**62)-1 for quite some time: https://github.com/DataDog/dd-trace-rb/blob/09c08622ea7f7ca4e193ea6bca6daec4cde3e8cb/lib/datadog/tracing/utils.rb#L13-L20
Additional Notes
Reviewer checklist