Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reorganize event management pages #20401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Oct 30, 2023

What does this PR do? What is the motivation?

  • Add ingest and usage pages to left nav and reorganize content
  • Move images to respective folders
  • Change reference links to new pages
  • DOCS-5997

Merge instructions

  • Please merge after reviewing

@estherk15 estherk15 requested a review from a team as a code owner October 30, 2023 18:44
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Oct 30, 2023
@maycmlee
Copy link
Contributor

maycmlee commented Oct 31, 2023

Created DOCS-6603

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review label Oct 31, 2023
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some light feedback.


- Normalize disparate sources of events by remapping attributes. For example, use the same reserved [service tags][19] everywhere.
- Enrich events with external data saved in a [Reference Table][20] (beta). For example, map a service name with your service directory to enrich events with team ownership information, links to dashboards, or links to documentation.
{{< img src="service_management/events/events_explorer.png" alt="Events explorer display" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this screenshot has a Datadog employee email in it. I would recommend retaking this screenshot. If you need to, you can change the email displayed in the UI (and make it something generic) using developer tools > Inspect in the browser. Reach out if you need any help doing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reevaluated whether we need another picture of the Events Explorer and removed. Thanks for catching this!

estherk15 and others added 3 commits November 3, 2023 13:31
@estherk15 estherk15 merged commit 4dc5bf7 into master Nov 3, 2023
@estherk15 estherk15 deleted the esther/docs-5997-ingest-usage-events branch November 3, 2023 20:50
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
* Add usage and ingest pages to menu work on usage

* Rearrange content and image files

* Change reference links from other docs

* Apply suggestions from code review

Co-authored-by: DeForest Richards <[email protected]>

* Remove image reference

---------

Co-authored-by: DeForest Richards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants