Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adjust best practices for recommended monitors #20840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

estherk15
Copy link
Contributor

What does this PR do? What is the motivation?

  • Add best practices and examples for Title and Description of recommended monitors

Merge instructions

  • Please merge after reviewing

@estherk15 estherk15 requested review from a team as code owners November 29, 2023 21:05
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good overall and approved!

With that said, I just wanted to point out that the Description in the screenshot of the "well-defined monitor" below your update is out of compliance with the Description guidelines you're providing in the table -- looks like it would fall under the Needs revision category. I'll let you decide whether to merge this now or update the screenshot first

@estherk15
Copy link
Contributor Author

Nice, looks good overall and approved!

With that said, I just wanted to point out that the Description in the screenshot of the "well-defined monitor" below your update is out of compliance with the Description guidelines you're providing in the table -- looks like it would fall under the Needs revision category. I'll let you decide whether to merge this now or update the screenshot first

Thanks @buraizu! I didn't even pay attention to that image!

@eho1307
Copy link
Contributor

eho1307 commented Nov 30, 2023

Hi! was there a reason we remove the image of the well defined monitor?

@estherk15
Copy link
Contributor Author

Hi! was there a reason we remove the image of the well defined monitor?

Hi @eho1307, the image doesn't follow the new best practices for monitor title and descriptions. I think the directions are pretty clear on how to create a monitor and what is and isn't a well-defined monitor. I think that might be enough. Let me know if you disagree!

@eho1307
Copy link
Contributor

eho1307 commented Dec 5, 2023

Hi! was there a reason we remove the image of the well defined monitor?

Hi @eho1307, the image doesn't follow the new best practices for monitor title and descriptions. I think the directions are pretty clear on how to create a monitor and what is and isn't a well-defined monitor. I think that might be enough. Let me know if you disagree!

Noted and approved from my end.

@estherk15 estherk15 merged commit f748ec7 into master Dec 5, 2023
@estherk15 estherk15 deleted the esther/update-recommended-monitors branch December 5, 2023 14:57
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
* Adjust best practices for recommended monitors

* Remove image of monitor configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants