-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adjust best practices for recommended monitors #20840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good overall and approved!
With that said, I just wanted to point out that the Description
in the screenshot of the "well-defined monitor" below your update is out of compliance with the Description guidelines you're providing in the table -- looks like it would fall under the Needs revision
category. I'll let you decide whether to merge this now or update the screenshot first
Thanks @buraizu! I didn't even pay attention to that image! |
Hi! was there a reason we remove the image of the well defined monitor? |
Hi @eho1307, the image doesn't follow the new best practices for monitor title and descriptions. I think the directions are pretty clear on how to create a monitor and what is and isn't a well-defined monitor. I think that might be enough. Let me know if you disagree! |
Noted and approved from my end. |
* Adjust best practices for recommended monitors * Remove image of monitor configuration
What does this PR do? What is the motivation?
Merge instructions