[SDCI] add message about gitlab test settings potentially failing #24833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
estherk15
reviewed
Aug 23, 2024
Co-authored-by: Esther Kim <[email protected]>
|
@estherk15 this is ready to be merged :) Thanks for the review |
estherk15
approved these changes
Aug 27, 2024
rtrieu
pushed a commit
that referenced
this pull request
Sep 3, 2024
…4833) * [SDCI] add message about gitlab test settings potentially failing * Apply suggestions from code review Co-authored-by: Esther Kim <[email protected]> --------- Co-authored-by: Esther Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
We had reports from customers that the validation through "Test settings" was failing but everything was working after saving. I prefer to add this to the documentation in case customers stop the setup because of it.
Merge instructions
Additional notes