Add new helm command. #24905
Merged
Add new helm command. #24905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
dineshg13
reviewed
Aug 26, 2024
Comment on lines
307
to
309
| helm upgrade -i <RELEASE_NAME> datadog/datadog \ | ||
| -f datadog-values.yaml \ | ||
| --set-file datadog.otelCollector.config=otel-config.yaml |
There was a problem hiding this comment.
Don't replace it. Add it as additional command, in case customers want to bring their own collector config
There was a problem hiding this comment.
Ah, gotcha. Fixed! Let me know if you have any other feedback.
hestonhoffman
approved these changes
Aug 26, 2024
dineshg13
approved these changes
Aug 27, 2024
rtrieu
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Add new helm command. * Use both commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Merge instructions
Additional notes