[apm/python] Add OpenTracing reference + small fixes #3119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFallUpHill
requested changes
Sep 10, 2018
content/tracing/setup/python.md
Outdated
| @@ -94,10 +94,16 @@ The ddtrace library includes support for the following libraries: | |||
| | [httplib](https://docs.python.org/2/library/httplib.html) | Fully Supported | http://pypi.datadoghq.com/trace/docs/other_integrations.html#httplib | | |||
| | [Requests](http://docs.python-requests.org/en/master/) | Fully Supported | http://pypi.datadoghq.com/trace/docs/other_integrations.html#requests | | |||
|
|
|||
| ## OpenTracing | |||
There was a problem hiding this comment.
I don't think we should have this section here, unless we add it back to each of the languages.
Voting against it to reduce fragmentation. I think this messaging should go into the Advanced Usage section at the top of the Python tab.
iFallUpHill
approved these changes
Sep 10, 2018
iFallUpHill
approved these changes
Sep 10, 2018
|
@l0k0ms this can be merged when you get the chance 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a reference to new Python OpenTracing functionality in the Python tracer.
Motivation
New feature.
Preview link
Additional Notes
Please wait until we release the feature before merging this PR.