Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New Log Guide: keep control on sensitive data flowing in logs #8967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 10, 2020

Conversation

pcarioufr
Copy link
Contributor

@pcarioufr pcarioufr commented Nov 2, 2020

What does this PR do?

Motivation

Preview

Additional Notes


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@pcarioufr pcarioufr requested a review from a team as a code owner November 2, 2020 08:22
@github-actions github-actions bot added Guide Content impacting a guide logs Content changed in the log folder labels Nov 2, 2020
@github-actions github-actions bot added the Images Images are added/removed with this PR label Nov 2, 2020
@pcarioufr pcarioufr added the Do Not Merge Just do not merge this PR :) label Nov 2, 2020

## Introduction

Logs are prone to hold sensitive data, and therefore need a specific care from a compliance standpoint. There are two approaches regarding sensitive data management:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need specific care

In case you have specific compliance questions or need a helping hand in fixing this, feel free to reach out to our support ([email protected]). Helpful information to support you are:

* The sensitive outline query. Or anything that could define sensitive data such as a timerange, a service or an environment,
* Whether the sensitive data still leaking into Datadog,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether the sensitive data is still

Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed grammatical feedback when I fixed the md issue, see changes here - af9d51a

@pcarioufr
Copy link
Contributor Author

@apigirl Since your last review, I brought a bit of structure on the Guide Page, following APM's Guides page model.

@pcarioufr pcarioufr changed the title New Log Guide: Use Query-Based Access Controls to handle sensitive data leaking New Log Guide: keep control on sensitive data flowing in logs Nov 3, 2020
@pcarioufr
Copy link
Contributor Author

@apigirl I also changed the title, along with the name of the file, for something less focused on the Query Based Access Controls part (which is only one optional step in the bigger picture).

@apigirl
Copy link
Contributor

apigirl commented Nov 4, 2020

@apigirl I also changed the title, along with the name of the file, for something less focused on the Query Based Access Controls part (which is only one optional step in the bigger picture).

I actually changed it again - let me know what you think

@pcarioufr pcarioufr removed the Do Not Merge Just do not merge this PR :) label Nov 4, 2020
@apigirl apigirl added the Do Not Merge Just do not merge this PR :) label Nov 9, 2020
@apigirl apigirl removed the Do Not Merge Just do not merge this PR :) label Nov 10, 2020
@apigirl apigirl merged commit 2c73277 into master Nov 10, 2020
@apigirl apigirl deleted the pcarioufr/restrict_access_sensitive_data branch November 10, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide Images Images are added/removed with this PR logs Content changed in the log folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants