Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WEB-1227] Site & Language Selector style fixes #9978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

[WEB-1227] Site & Language Selector style fixes #9978

merged 1 commit into from
Mar 8, 2021

Conversation

bgdeutsch
Copy link
Collaborator

What does this PR do?

Fixes two style bugs in site & language selectors

Motivation

https://datadoghq.atlassian.net/browse/WEB-1227
https://dd.slack.com/archives/C3CT8QA11/p1615234380056000
https://dd.slack.com/archives/C3CT8QA11/p1615234440057300

Preview

https://docs-staging.datadoghq.com/brian.deutsch/site-lang-selector-style-fix/dashboards/

  • There should be no style bug when opening the Language selector. In live this bug can be reproduced only between 991 and 1200px screen width. Both selectors should function and look correct at all screen sizes. Originally reported in the Jira ticket linked above.

https://docs-staging.datadoghq.com/brian.deutsch/site-lang-selector-style-fix/api/latest/synthetics/

  • Buttons from API examples, programming lang selectors, copy code function, etc should all be hidden under the sticky header (with breadcrumbs/site & lang selectors) as the user scrolls down the page. In live this bug is found across API pages. Originally reported in #Websites channel via the Slack links above.

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@bgdeutsch bgdeutsch requested review from a team as code owners March 8, 2021 21:31
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Mar 8, 2021
apigirl
apigirl approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@apigirl apigirl merged commit f273a9d into master Mar 8, 2021
@apigirl apigirl deleted the brian.deutsch/site-lang-selector-style-fix branch March 8, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleegoodspeed stanleegoodspeed stanleegoodspeed approved these changes

@apigirl apigirl apigirl approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgdeutsch @stanleegoodspeed @apigirl