correctly handle ESCAPE '\'#57
Merged
Merged
Conversation
nenadnoveljic
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue #56 where the lexer would incorrectly handle the ESCAPE clause when using a backslash character. Previously, when parsing a query like:
The lexer would incorrectly treat
'\'as an incomplete string instead of a valid string token containing a single backslash character.The
scanStringmethod was not properly handling the case where a backslash character appears before a quote. In the ESCAPE clause context, the backslash is treated as a literal character rather than an escape character.Modified the
scanStringmethod to track escaped quotes separately from the general escape state. This allows us to:'\'123')ESCAPE '\')Testing
The fix has been verified with test cases covering:
ESCAPE '\''\'123''%\_temp\_%'