Stephans Models #307
Stephans Models #307
Conversation
|
This PR has all of Stephan's Models with constraint checking. They have been added to the existing structure. |
|
Additional formatting in 33307f7 |
Entenwilli
left a comment
There was a problem hiding this comment.
That's a lot of new models (and test cases 🎉)
Some smaller notes:
- Consistent naming of edges: Use snake_case
- Consistent naming of nodes: Use Title Case (you can and should use spaces here!)
- There seem to be some changes in the automatically generated code (from one commit), please revert or exclude that commit from this PR
There was a problem hiding this comment.
Shouldn't this Model have two constraints?
The existing one is correct, but as I understand there should also be the constraint that only managers are allowed to access data from a different region (e.g. ManagerUSA -> Asia, but not ClerkUSA -> Asia)
|
@Entenwilli The current issue during the build seems to be something we have encountered before. Can you please look at it, so we can finally merge this PR? I think it should be high priority |
The workflow fails in this case, because there are some violations missing and some that are not properly defined for the Private Taxi and Distance Tracker example model. From having a quick glance at the models, I would say the propagation results look correct, so the issue is most likely the constraint or the defined expected violations |
|
This PR is completely succeeded by #340 . |
I added the .datadictionary, .dataflowdiagram and .json files for all of Stephan's Models.
Each Model has a corresponding Result file now and ExampleModelsTest.java was changed accordingly.
All Tests run through.