The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
agui-chat-deepcitation	Ignored	Preview	Apr 12, 2026 1:45pm
deepcitation-langchain-rag-chat	Ignored	Preview	Apr 12, 2026 1:45pm
mastra-rag-deepcitation	Ignored	Preview	Apr 12, 2026 1:45pm
nextjs-ai-sdk-deepcitation	Ignored	Preview	Apr 12, 2026 1:45pm

✅ Playwright Test Report

Status: Tests passed

📊 Download Report & Snapshots (see Artifacts section)

Run ID: 24308142691

Code Review

Overall: This is a well-targeted, minimal fix for a real bug. The logic is correct and the refactor is clean. A few things worth addressing before merge:

What's Good

• Fix is correct. resolveField tries the canonical name first, so existing citations with sourceContext/sourceMatch are unaffected. The regression fixture hashes will stay identical.
• Hoisting rawCitation eliminates the repeated as unknown as Record<string, unknown> cast — cleaner and easier to audit.
• Comment quality improved: the new comment names the specific old-CLI aliases (fullPhrase, anchorText) rather than the vague "LLMs sometimes emit...".

Issues

1. Missing test coverage for the bug being fixed (important)

The PR description says to verify that old-CLI field names produce the same key as canonical names, but citationKeyStability.test.ts has no test for this. If someone later removes fullPhrase or anchorText from FIELD_ALIAS_MAP, the bug silently regresses with no red test.

Suggested addition to citationKeyStability.test.ts:

describe("getCitationKey alias resolution", () => {
  it("old-CLI fullPhrase/anchorText aliases hash identically to canonical names", () => {
    const canonical: DocumentCitation = {
      type: "document",
      sourceContext: "Revenue grew 45% year-over-year to $2.3B",
      sourceMatch: "$2.3B",
      pageNumber: 2,
      lineIds: [20],
    };
    // Simulate an old-CLI citation with legacy field names
    const legacyCli = {
      type: "document",
      fullPhrase: "Revenue grew 45% year-over-year to $2.3B",
      anchorText: "$2.3B",
      pageNumber: 2,
      lineIds: [20],
    } as unknown as DocumentCitation;

    expect(getCitationKey(legacyCli)).toBe(getCitationKey(canonical));
  });

  it("old-CLI citations no longer hash as empty string (regression guard)", () => {
    const legacyCli = {
      type: "document",
      fullPhrase: "Some context",
      anchorText: "context",
    } as unknown as DocumentCitation;
    const emptyKey = getCitationKey({ type: "document" } as DocumentCitation);

    expect(getCitationKey(legacyCli)).not.toBe(emptyKey);
  });
});

2. getVerificationKey does not use resolveField

getVerificationKey in the same file accesses verification.verifiedSourceContext and verification.verifiedSourceMatch directly. If verifications can arrive via a similar old-CLI path with aliased field names, it has the same bug. If verifications are always server-generated with canonical names this is fine — but worth a comment confirming that assumption to prevent a future copy-paste bug.

Minor Notes

• The cast (resolveField(rawCitation, "sourceContext") as string) || "" is appropriate here — resolveField returns unknown by design, and this matches the pre-existing pattern for resolvedStartPageId.
• lineIds and pageNumber are still accessed directly via citation.lineIds and citation.pageNumber. These fields don't appear to have old-CLI aliases in FIELD_ALIAS_MAP that would carry non-undefined values, so this is fine, but worth confirming.

Summary: The core fix is correct. Before merging, please add the alias-variant test case so the bug can't regress silently. The getVerificationKey concern is lower priority but worth acknowledging.