feat(cli): preserve per-attachment assets in verify output#430
Conversation
Collect the attachments map (pageImages, originalDownload) from each verifyAttachment result and merge it into the final output JSON so callers like updateDemoVerifications.ts can enrich demo data with page images. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Matches the identical pattern already used in the second verify function (line 1263) instead of widening to Record<string, unknown>. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
Code Review
|
✅ Playwright Test ReportStatus: Tests passed 📊 Download Report & Snapshots (see Artifacts section) What's in the Visual SnapshotsThe gallery includes visual snapshots for:
Run ID: 24483084563 |
- Narrow output type from Record<string,unknown> to explicit shape - Write attachments to verify-response.json in both verify paths - Add invariant comments on Object.assign(mergedAttachments) - Add unit tests for attachments present/absent in output file - Fix README tagline slash and capitalisation - Simplify quota error message to remove stale pricing copy Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
- Update cliUnit.test.ts assertions to match simplified quota message (removed stale "Standard"/"Pro" tier copy from PaymentRequiredError) - Fix tsconfig.jest.json: "6.0" is invalid under TS 5.9; downgrade to "5.0" - Remove trailing blank line in markdownToHtml.ts (biome auto-fix) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The package requires typescript ^6.0.2; TS 6 requires "6.0" to silence the moduleResolution=node10 deprecation (TS5107). The prior commit incorrectly downgraded to "5.0" due to missing local node_modules. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Summary
attachmentsmap (pageImages, originalDownload) from eachverifyAttachmentresult and merges it into the finalverify-response.jsonoutput, alongside the existingverificationsmapattachmentswhen at least one attachment returned assets (no empty object noise)mergedAttachmentstyped asRecord<string, AttachmentAssets>for consistency with the parallel pattern in the second verify functionTest plan
npx deepcitation verifyagainst a multi-attachment input; confirmverify-response.jsoncontains bothverificationsandattachmentskeysattachmentskey is absent from outputbun run lintpasses (no new lint errors)