chore(deps): update helm release redis from 19.6.4 to v20 (helm/defectdojo/chart.yaml) - autoclosed #10736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun Security SummaryHelm chart for DefectDojo updated Redis chart dependency from version 19.6.4 to 20.11.4, with no identified security vulnerabilities but recommended careful review of potential configuration changes. Expand for full summarySummary: Helm chart updates for DefectDojo, specifically modifying Redis chart dependency from version 19.6.4 to 20.11.4, with no direct security vulnerabilities identified. Security Findings:
Note: While no direct vulnerabilities were detected, the significant version jump in the Redis Helm chart could potentially introduce configuration changes that should be carefully reviewed during deployment. |
mtesauro
previously approved these changes
Aug 9, 2024
cneill
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Looks like this version of the chart is using Redis 7.4.0, which we've held off on elsewhere:
❯ helm search repo bitnami/redis -l
NAME CHART VERSION APP VERSION DESCRIPTION
bitnami/redis 20.0.1 7.4.0 Redis(R) is an open source, advanced key-value ...
bitnami/redis 20.0.0 7.4.0 Redis(R) is an open source, advanced key-value ...
|
@cneill Good catch - that licensing change would likely not be expected by those using the helm chart in this repo beyond it not matching the upstream version Let's sit on this for now 👍 |
4a66881 to
957b1fb
Compare
9393dca to
1a1fb89
Compare
1a1fb89 to
6a64d6e
Compare
82d3143 to
0f7f428
Compare
|
Just for the record, this is from a scan on the current version of DD (chart version 1.6.178):
|
|
One thing you might not be aware of is that OWASP requires projects to have an OSI approved license. DefectDojo is an OWASP project and in addition to other concerns, mixing an OSI license with a non-OSI license for a key component muddies up the projects license story. We're still reviewing options but, for now, we're sticking with the pre-license change version of Redis. This is an open source project and you're welcome & free to use whatever version of Redis suits your needs. Just update the container reference (compose) or Helm (k8s) accordingly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
5741e90 to
3f81691
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
3f81691 to
6544620
Compare
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
6544620 to
9e8723d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
~19.6.0->~20.13.0Release Notes
bitnami/charts (redis)
v20.13.4v20.13.3v20.13.2v20.13.1v20.13.0v20.12.2v20.12.1v20.12.0v20.11.5kubectl-sharedcontainer (#32085) (dad454d), closes #32085v20.11.4v20.11.3v20.11.2v20.11.1v20.11.0v20.10.1v20.10.0usePasswordFiles=trueby default (#32117) (2f80b74), closes #32117v20.9.0v20.8.0v20.7.1v20.7.0v20.6.3v20.6.2v20.6.1v20.6.0v20.5.0v20.4.1v20.4.0v20.3.0v20.2.2v20.2.1v20.2.0v20.1.7v20.1.6v20.1.5v20.1.4v20.1.3v20.1.2v20.1.1v20.1.0v20.0.5v20.0.4v20.0.3v20.0.2v20.0.1v20.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.