Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SLA Calculations 1/2: Add unit tests to capture current behaviour #11923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 20, 2025

Conversation

valentijnscholten
Copy link
Member

Adds some unit tests to capture current behaviour:

  • to understand the calculation that does some magic with days remaining
  • to make sure we don't regress in the future if we simplify the calculation, or add business days support.

@github-actions github-actions bot removed the ui label Mar 1, 2025
@valentijnscholten valentijnscholten changed the title SLA Calculations: Add unit tests to capture current behaviour SLA Calculations 1/2: Add unit tests to capture current behaviour Mar 6, 2025
@valentijnscholten valentijnscholten marked this pull request as ready for review March 12, 2025 17:25
Copy link

DryRun Security Summary

A new unit test file for SLA calculations in DefectDojo is added, with five test methods and a security finding related to potential information disclosure through logging configuration.

Expand for full summary

The PR introduces a new unit test file for SLA calculations in DefectDojo, implementing five test methods to validate various SLA scenarios. Security findings include: 1) Potential information disclosure risk from logging configuration if log levels are not properly set in production, as noted in the file's security analysis section.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit c7331cc into DefectDojo:bugfix Mar 20, 2025
71 checks passed
iago-r pushed a commit to iago-r/django-DefectDojo that referenced this pull request Mar 27, 2025
…fectDojo#11923)

* sla calc: add unit tests

* sla calc: add unit tests

* sla calc: add unit tests

* linting

* sla config: restore display tag

* sla config: restore display tag

* sla config: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants