Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 fix benchmark internal server error #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2025
Merged

🐛 fix benchmark internal server error #11974

merged 2 commits into from
Mar 7, 2025

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Mar 7, 2025 •
edited
Loading

fix for #11973

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 7, 2025 •
edited
Loading

DryRun Security Summary

The PR modifies Django benchmark files by renaming the type parameter to benchmark_type to enhance code readability, with no security issues detected.

Expand for full summary

The PR updates URL routing and view filtering in benchmark-related Django files, renaming the type parameter to benchmark_type for improved code clarity. No security vulnerabilities were found in the reviewed changes.

Code Analysis

We ran 7 analyzers against 2 files and 1 analyzer had findings. 6 analyzers had no findings.

Analyzer Findings
IDOR Analyzer 1 finding

Overall Riskiness

🟡 Please give this pull request extra attention during review.

View PR in the DryRun Dashboard.

@kiblik
Copy link
Contributor

kiblik commented Mar 7, 2025

I suppose it will be better to fix URLs. Similar to https://github.com/DefectDojo/django-DefectDojo/pull/11949/files

@manuel-sommer manuel-sommer marked this pull request as draft March 7, 2025 15:07
@manuel-sommer
Copy link
Contributor Author

yeah, it is still a draft

@manuel-sommer manuel-sommer marked this pull request as ready for review March 7, 2025 15:35
@manuel-sommer
Copy link
Contributor Author

Ready to review @kiblik

@manuel-sommer
Copy link
Contributor Author

Maybe we can merge this fix for the next release @mtesauro ?

mtesauro
mtesauro approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 4978d90 into DefectDojo:bugfix Mar 7, 2025
77 checks passed
@manuel-sommer manuel-sommer deleted the fix_11973 branch March 9, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grendel513 grendel513 grendel513 approved these changes

@mtesauro mtesauro mtesauro approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

@blakeaowens blakeaowens blakeaowens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@manuel-sommer @kiblik @grendel513 @mtesauro @hblankenship @Maffooch @blakeaowens