Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dedupe command: fix NoneType on empty set of models #11998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

dedupe command: fix NoneType on empty set of models #11998

merged 1 commit into from
Mar 20, 2025

Conversation

valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Mar 12, 2025 •
edited
Loading

Encounted by a user on Slack.

Fixes a NoneType error when the selected set of models for mass update is actually empty.

@valentijnscholten valentijnscholten marked this pull request as ready for review March 12, 2025 17:58
@dryrunsecurity DryRunSecurity
Copy link

DryRun Security Summary

The pull request modifies the pagination logic in the mass_model_updater function within dojo/utils.py, prioritizing descending order processing while maintaining existing functionality.

Expand for full summary

The PR updates the mass_model_updater function in dojo/utils.py, modifying pagination logic for model updates with a focus on descending order processing. No security vulnerabilities found.

View PR in the DryRun Dashboard.

mtesauro
mtesauro approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit a0376de into DefectDojo:bugfix Mar 20, 2025
76 checks passed
iago-r pushed a commit to iago-r/django-DefectDojo that referenced this pull request Mar 27, 2025
@valentijnscholten
dedupe command: fix NoneType on empty set of models (DefectDojo#11998)
69d0aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valentijnscholten @mtesauro @dogboat @hblankenship @Maffooch