Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add aqua vulnerabilities format #12000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

add aqua vulnerabilities format #12000

merged 3 commits into from
Mar 20, 2025

Conversation

kzzz1
Copy link
Contributor

@kzzz1 kzzz1 commented Mar 12, 2025 •
edited
Loading

see discussion in #11957

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 12, 2025 •
edited
Loading

DryRun Security Summary

The pull request enhances the Aqua parser documentation and functionality by adding a new scan report format, introducing unit tests, and revealing potential security considerations related to information exposure and input validation.

Expand for full summary

  1. Summary: The PR updates Aqua parser documentation, adds support for a new Aqua Scan Report format, introduces a new unit test JSON file, and creates corresponding unit tests for the Aqua parser.

  2. Security Findings:

  • Placeholder URLs and endpoints revealed in documentation that provide insight into Aqua's API structure
  • Potential information exposure through unique key generation in parser that includes CPE and file paths
  • Lack of explicit input validation in the parser for new "result" key and its contents
  • No robust error handling for malformed or unexpected input structures
  • Test JSON file reveals specific configuration details like registry name and image name
  • Potential reconnaissance information through exposed query parameters in test JSON
  • Reliance on path resolution function in unit tests could be a potential security consideration

View PR in the DryRun Dashboard.

@kzzz1 kzzz1 marked this pull request as draft March 12, 2025 19:42
@kzzz1 kzzz1 marked this pull request as ready for review March 12, 2025 19:48
@valentijnscholten
Copy link
Member

Thank you. Could you look at adding some info to https://github.com/DefectDojo/django-DefectDojo/blob/master/docs/content/en/connecting_your_tools/parsers/file/aqua.md to:

  • list the supported reports/formats
  • how each format can be generated

@github-actions github-actions bot added the docs label Mar 17, 2025
@kzzz1
Copy link
Contributor Author

kzzz1 commented Mar 17, 2025

Added some documentation for the parser, @valentijnscholten .

@valentijnscholten
Copy link
Member

Thanks, just approved the test suit to run.

@valentijnscholten valentijnscholten changed the title add aqua format add aqua rest api format Mar 18, 2025
@valentijnscholten valentijnscholten changed the title add aqua rest api format add aqua vulnerabilities format Mar 18, 2025
mtesauro
mtesauro approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit ab3e571 into DefectDojo:bugfix Mar 20, 2025
77 checks passed
iago-r pushed a commit to iago-r/django-DefectDojo that referenced this pull request Mar 27, 2025
@kzzz1
add aqua vulnerabilities format (DefectDojo#12000)
c9056bd 
* add aqua scan format report for api v2

* fix ruff

* Update aqua.md

---------

Co-authored-by: kzzz1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
docs parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kzzz1 @valentijnscholten @mtesauro @dogboat @hblankenship @Maffooch