Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ruff: Add TD007 and N803 #12002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

Ruff: Add TD007 and N803 #12002

merged 2 commits into from
Mar 20, 2025

Conversation

manuel-sommer
Copy link
Contributor

No description provided.

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 12, 2025 •
edited
Loading

DryRun Security Summary

A pull request updates code naming conventions from camelCase to snake_case across multiple files to align with Python's PEP 8 style guidelines, without introducing any security issues.

Expand for full summary

The pull request introduces naming convention updates across multiple files, changing camelCase parameter names to snake_case in various parsers, test files, and configuration files. No security vulnerabilities were found in these changes, which are purely stylistic and follow Python's PEP 8 naming conventions.

View PR in the DryRun Dashboard.

@kiblik
Copy link
Contributor

kiblik commented Mar 12, 2025

Rule description says

Checks for argument names that do not follow the snake_case convention.

I would also follow snake_case if possible because simple lowering of camelCase to flatcase makes it harder to read.

mtesauro
mtesauro approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 4ef3be4 into DefectDojo:dev Mar 20, 2025
77 checks passed
@manuel-sommer manuel-sommer deleted the TD007 branch March 20, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@kiblik kiblik kiblik approved these changes

@dogboat dogboat dogboat approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
lint parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manuel-sommer @kiblik @mtesauro @dogboat @Maffooch