Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(helm-metrics): Flag format for promExporter changed #12010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix(helm-metrics): Flag format for promExporter changed #12010

merged 1 commit into from
Mar 20, 2025

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Mar 14, 2025

For nginx-prometheus-exporter from v1.0.0, the flag format was changed. Old is still not deprecated, but there is already a warning:

the flag format is deprecated and will be removed in a future release, please use the new format: --nginx.scrape-uri

@github-actions github-actions bot added the helm label Mar 14, 2025
@dryrunsecurity DryRunSecurity
Copy link

DryRun Security Summary

Django deployment configuration for nginx-prometheus-exporter was updated with CLI flag changes and metrics endpoint configuration, but with identified network security risks involving unencrypted HTTP endpoints and potential configuration exposure.

Expand for full summary
  1. Updated Django deployment configuration for nginx-prometheus-exporter with a CLI flag modification and metrics endpoint configuration.

Security Findings:

  • Network Security Risk: Metrics exporter uses unencrypted HTTP endpoint (http://127.0.0.1:8080/nginx_status)
  • Configuration Exposure: Metrics endpoint exposed on port 9113 without additional authentication
  • Potential Security Concern: Prometheus metrics annotations enabled with unencrypted HTTP scheme

View PR in the DryRun Dashboard.

mtesauro
mtesauro approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 1b259e1 into DefectDojo:bugfix Mar 20, 2025
76 checks passed
@kiblik kiblik deleted the helm_django_metrics_flag_scrape branch March 20, 2025 07:14
iago-r pushed a commit to iago-r/django-DefectDojo that referenced this pull request Mar 27, 2025
@kiblik
fix(helm-metrics): Flag format for promExporter changed (DefectDojo#1…
1ff64e4 
…2010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @mtesauro @dogboat @hblankenship @Maffooch