Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add resources to wait-for-db #12023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hoferbeck
Copy link
Contributor

⚠️ Note on feature completeness ⚠️

We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md

Description

Describe the feature / bug fix implemented by this PR.
If the Kubernetes Namespace has ResourceQuotas set. the "wait-for-db" pod is unable to start, as resources are forced to be set.
For simplicity, I would use the same resources as for the main container from the Job

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • [ x ] Bugfixes should be submitted against the bugfix branch.
  • [ x ] Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is flake8 compliant.
  • Your code is python 3.11 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Model changes must include the necessary migrations in the dojo/db_migrations folder.
  • Add applicable tests to the unit tests.
  • [] Add the proper label to categorize your PR.

@github-actions github-actions bot added the helm label Mar 16, 2025
Copy link

DryRun Security Summary

The PR introduces a resources configuration block to the wait-for-db init container in the Helm template to enable more precise resource allocation for database initialization.

Expand for full summary
  1. The PR adds a resources configuration block to the wait-for-db init container in the Helm template, allowing more granular resource allocation for the database initialization container.

  2. Security Findings:

  • No security vulnerabilities found.

View PR in the DryRun Dashboard.

Copy link
Contributor

@kiblik kiblik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 039218a into DefectDojo:bugfix Mar 25, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants