Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Generic JSON: Explicitly process tags like other tools #12056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

Generic JSON: Explicitly process tags like other tools #12056

merged 3 commits into from
Mar 21, 2025

Conversation

Maffooch
Copy link
Contributor

I noticed that the generic json parser did not make use of the unsaved_tags field like other parsers to. We should be consistent here

[sc-10594]

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 20, 2025 •
edited
Loading

DryRun Security Summary

Updated JSON parser and unit tests to improve handling of unsaved tags with modifications to processing logic, with no identified security vulnerabilities.

Expand for full summary

Summary of Changes:
Updated JSON parser and corresponding unit tests to support handling of unsaved tags, modifying tag processing logic in both the parser and test methods.

Security Findings:

  • No security vulnerabilities were found in the provided patches.

View PR in the DryRun Dashboard.

mtesauro
mtesauro approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 0a0a460 into bugfix Mar 21, 2025
79 checks passed
@Maffooch Maffooch deleted the generic-unsaved-tags branch March 21, 2025 00:01
iago-r pushed a commit to iago-r/django-DefectDojo that referenced this pull request Mar 27, 2025
@Maffooch
Generic JSON: Explicitly process tags like other tools (DefectDojo#12056
72fcd6d 
)

* Generic JSON: Explicitly process tags like other tools

* Update tests

* Remove extra cruft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneill cneill cneill approved these changes

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@blakeaowens blakeaowens blakeaowens approved these changes

Assignees
No one assigned
Labels
parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Maffooch @cneill @mtesauro @dogboat @blakeaowens