Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 fix gitlab dast to parse request response pair #12050 #12057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

manuel-sommer
Copy link
Contributor

Copy link

DryRun Security Summary

GitLab DAST parser enhancement introduces potential security risks through unsanitized header processing and exposure of sensitive information in request/response details.

Expand for full summary

Summary of Changes:
Introduced enhancements to GitLab DAST parser, adding new method to process request/response details and a corresponding unit test to validate parsing functionality.

Security Findings:

  1. Potential Information Exposure (dojo/tools/gitlab_dast/parser.py):

    • Direct inclusion of full request and response headers could expose sensitive information
    • No sanitization of header values
    • Risk of revealing authentication tokens or internal system details
  2. Sensitive Information in Test Fixture (unittests/scans/gitlab_dast/issue_12050.json):

    • Contains partially masked credit card number
    • Exposed HTTP (non-secure) API endpoint
    • Includes masked Authorization header
    • High severity PII disclosure (CWE-359)
    • CVE: 10062
  3. Network Security Concerns:

    • Exposed internal hostname "api-server"
    • Uses unsecured HTTP protocol
    • Potential authentication token exposure
  4. Header Processing Risks:

    • No explicit sanitization of header names or values
    • Potential string formatting vulnerabilities
    • Minimal error handling for malformed evidence
  5. Information Disclosure Risks:

    • Full request/response details stored without filtering
    • Potential exposure of sensitive system metadata
    • User agent and timestamp information included

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit c65a068 into DefectDojo:bugfix Mar 25, 2025
76 checks passed
@manuel-sommer manuel-sommer deleted the issue_12050 branch March 25, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants