sso docs: make environment variables vs local_settings more explicit #12061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun Security SummaryDefectDojo's documentation for SSO configuration was updated to provide clearer instructions for environment variable settings across authentication providers, with a focus on improving configuration clarity without introducing security vulnerabilities. Expand for full summary
|
|
Looks good, thank you Val |
1765f31 to
f4e1aef
Compare
f4e1aef to
162ca35
Compare
Maffooch
approved these changes
Mar 21, 2025
dogboat
approved these changes
Mar 25, 2025
hblankenship
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently this text was improved. I suggest a further improvement. Mainly to make it more clear that if users opt to put the environment variables inside local_settings.py, they need to remove the
DD_prefix.If this turns out to be still not clear for users I think we will have to remove any references to
local_settings.pyhere and just point to the open source configuration page which explains this in more detail.