Ruff: Add a lot of Bugbear rules #12077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun Security SummaryThe pull request updates the Ruff linter configuration by expanding the selected linting rules to enhance code quality and potentially improve security through broader code pattern analysis. Expand for full summary
|
Maffooch
approved these changes
Mar 24, 2025
dogboat
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Just highlighting the added rules:
- B011 - use of assert False
- B012 - break/continue/return in finally
- B013 - single-element tuples in exception handlers
- B014 - redundant exceptions in catch
- B015 - useless comparisons
- B016 - raising literals
- B019 - cached instance methods
- B020 - loop iterable overrides
- B021 - fstring docstrings
- B022 - contextlib.suppress without args
- B023 - function defs with loop var
- B025 - redundant try blocks
- B029 - except with empty tuples
- B030 - catch non-exception classes
- B032 - unintentional type annotations
- B034 - re.sub positional args
- B035 - static key dict comprehensions
- B039 - mutable contextvar defaults
- B901 - return in generator
- B911 - itertools.batched wihtout explicit param
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
hblankenship
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.