Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🎉 resolve todo in ort parser #12082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

🎉 resolve todo in ort parser #12082

merged 1 commit into from
Mar 25, 2025

Conversation

manuel-sommer
Copy link
Contributor

Resolve TODO

@dryrunsecurity DryRunSecurity
Copy link

DryRun Security Summary

The pull request modernizes type hinting in the dojo/tools/ort/parser.py file by replacing namedtuple with NamedTuple for the RuleViolationModel without introducing any security vulnerabilities.

Expand for full summary

  1. The PR updates the dojo/tools/ort/parser.py file, replacing namedtuple with NamedTuple for the RuleViolationModel using modern Python type hinting.

  2. Security Findings:

    • No security vulnerabilities found.

View PR in the DryRun Dashboard.

mtesauro
mtesauro approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit f11e28f into DefectDojo:bugfix Mar 25, 2025
76 checks passed
@manuel-sommer manuel-sommer deleted the resolve_ort_todo branch March 25, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manuel-sommer @mtesauro @dogboat @hblankenship @Maffooch