Import Memory Handling: Do not maintain parsed findings long term #12106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun Security SummaryThe code underwent a refactoring process to simplify parsing methods, remove redundant attributes, and improve overall code structure for default importer and reimporter classes without introducing any security vulnerabilities. Expand for full summary
|
hblankenship
approved these changes
Mar 26, 2025
dogboat
approved these changes
Mar 26, 2025
blakeaowens
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing many imports at once, it was noticed that memory of the redis container was maintaining a very high level. This is because the findings parsed from the submitted report were being saved on the Importer class, and in scope for the entire duration of the process. We should not maintain the list of parsed findings after they have been consumed
[sc-10595]