sla_config: use mass update for recalculation #12133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
4502fac to
622a011
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
DryRun Security SummaryA multi-file patch introduces potential security risks through modified logging practices, async task argument changes, and SLA configuration retrieval mechanisms that could expose sensitive information and bypass existing validation protections. Expand for full summarySummary: A patch across multiple files modifies SLA configuration, product, and utility functions with changes to logging, function signatures, and async task management. Security Findings:
• Potential Behavioral Changes
• Logging Considerations
• Model Update Mechanism
• SLA Configuration Retrieval
|
blakeaowens
reviewed
Apr 2, 2025
Maffooch
approved these changes
Apr 3, 2025
hblankenship
approved these changes
Apr 9, 2025
dogboat
approved these changes
Apr 9, 2025
Maffooch
pushed a commit
that referenced
this pull request
Apr 21, 2025
* sla_config_updater: add logging * sla_config: use mass update on changes * sla_config: use mass update on changes * sla_config: use mass update on changes * sla_config: use mass update on changes * sla_config: use mass update on changes * sla_config: use mass update on changes * sla_config: use mass update on changes * sla_config: use mass update on changes * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the updating of the
sla_expiration_datefield. A change to an SLA Configuration or Product can trigger a recalculation of this field for all affected findings.Before this PR this took ~8.5 minutes for 20k findings. This is on a i9 16 core with an NVM SSD.
This PR used the
mass_model_updaterfunction that has proven to work more efficiently. Now the job completes in ~30s time.Before this PR, every finding would be post processed in the background celery work. This isn't needed as a change to the SLA expiration doesn't affect dedupe or pushing to JIRA. Also the product grade would be calculated for each affected finding (so multiple times per product). This is not needed. This background work took over 30 minutes for 20k (I killed the instance after 30 minutes).
The PR also removes some code duplication.
I can imagine this change is also beneficial for Pro users where larger instances are more common, as well as more intensive usage of the instances.