Product Revenue: Do no allow negative revenue #12160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DryRun Security SummaryDatabase migration for the Product model includes adding input validation to prevent negative revenue values and improving decimal precision to enhance data integrity and reduce numeric precision vulnerabilities. Expand for full summarySummary: Database migration and model update for the Product model, focusing on revenue field modifications with input validation and decimal precision improvements. Security Findings:
No critical security vulnerabilities were identified in the provided summaries. |
hblankenship
approved these changes
Apr 3, 2025
dogboat
approved these changes
Apr 3, 2025
blakeaowens
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make sense for revenue to be a negative number. Because the revenue field is a decimal field, we must add a validator to disallow values less than 0
[sc-10753]