-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Ruff: Add S324 rule #12169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff: Add S324 rule #12169
Conversation
DryRun Security SummaryMultiple parser files in the dojo/tools directory were updated to add Expand for full summarySummary of Security Findings: Multiple files in the dojo/tools directory were updated with a consistent pattern of adding Security Vulnerabilities: No direct security vulnerabilities were found in the reviewed patches. The changes were primarily defensive coding practices that:
Specific Files Modified:
Additionally, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this might be more robust for future contributors in the ruff.toml
file under the [lint.per-file-ignores]
section:
"dojo/tools/**" = [
"S324", # https://docs.astral.sh/ruff/rules/hashlib-insecure-hash-function/
]
Question is. Do we want to do it easy (as it is proposed right now) or hard (as Ruff page recommends) :) I'm okay with the current setup. The recommended solution is to add |
Let's keep it this way please |
Great suggestion! @manuel-sommer do you have bandwidth to add this? |
done @Maffooch |
* fix * fix * Update ruff.toml --------- Co-authored-by: Cody Maffucci <[email protected]>
No description provided.