Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Session timeout notification" #12186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Apr 7, 2025

Reverts #12093

@Maffooch Maffooch requested a review from blakeaowens as a code owner April 7, 2025 14:35
@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui labels Apr 7, 2025
Copy link

dryrunsecurity bot commented Apr 7, 2025

DryRun Security Summary

A series of code changes remove session expiration warning functionality, potentially compromising user experience and security by eliminating proactive notifications about session timeouts.

Expand for full summary

Summary: A series of patches remove session expiration warning functionality across multiple files, eliminating client-side session timeout notifications and related configurations.

Security Findings:
• Session Management Vulnerability

  • Removal of session timeout notification mechanism eliminates user awareness of impending session expiration
  • Users may be unexpectedly logged out without warning
  • Potential usability and security impact by removing session timeout visibility

• Potential User Experience Security Risk

  • Elimination of proactive notifications about session timeout
  • Client-side session expiration warnings will no longer be automatically generated
  • Frontend components relying on session notifications will require updates

• Session Notification Removal

  • Deleted session_notifcation() JavaScript function
  • Removed session timeout modal from base HTML template
  • Eliminated context processor for session expiry tracking

View PR in the DryRun Dashboard.

@Maffooch Maffooch merged commit 781ae01 into dev Apr 7, 2025
78 checks passed
@Maffooch Maffooch deleted the revert-12093-session-timeout-notification branch April 7, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant