Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Import/Reimport Stats: Change name of left untouched #12193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2025
Merged

Import/Reimport Stats: Change name of left untouched #12193

merged 6 commits into from
Apr 11, 2025

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Apr 7, 2025

Following a successful import or reimport, a JSON blob for statistics is generated to provide the differential of finding activity. There was a section in the delta JSON blob that referred to a key labeled left untouched. This value does not comply with REST norms, and has been renamed to left_untouched.

[sc-6122]

@Maffooch Maffooch requested a review from mtesauro as a code owner April 7, 2025 21:55
@github-actions github-actions bot added New Migration Adding a new migration file. Take care when merging. docs unittests ui labels Apr 7, 2025
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Apr 7, 2025 •
edited
Loading

DryRun Security Summary

DefectDojo Version 2.46.x documentation and code updates involve renaming the 'left untouched' key to 'left_untouched' and identifying a potential input validation vulnerability in the display_tags.py template tag function.

Expand for full summary

Summary: DefectDojo Version 2.46.x documentation and code updates focus on renaming the "left untouched" key to "left_untouched" across multiple files, improving naming consistency.

Security Findings:

  1. Potential Input Validation Vulnerability in display_tags.py
    • Location: dojo/templatetags/display_tags.py
    • Risk: Lack of input validation in replace_underscore_with_space function
    • Explanation: Function does not check input type, which could potentially cause TypeError if non-string input is provided

No other direct security vulnerabilities were identified in the provided summaries.

View PR in the DryRun Dashboard.

@Maffooch Maffooch added this to the 2.46.0 milestone Apr 7, 2025
mtesauro
mtesauro approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten
Copy link
Member

valentijnscholten commented Apr 9, 2025 •
edited
Loading

I'm late to the party @Maffooch, but I think we should go with just "untouched" to avoid dealing with spaces/underscores etc.

@Maffooch
Copy link
Contributor Author

Maffooch commented Apr 9, 2025

@mtesauro what are your thoughts on Val's comment? I am not opposed to going with just untouched - it would actually simplify this PR a bit to do so

@mtesauro
Copy link
Contributor

I am good with just "untouched"

@Maffooch
Copy link
Contributor Author

@valentijnscholten thanks for raising that! We will go with untouched

@github-actions github-actions bot removed the ui label Apr 11, 2025
@dryrunsecurity DryRunSecurity
Copy link

DryRun Security

This pull request contains a documentation and code patch for DefectDojo version 2.46.x with terminology updates and no identified security vulnerabilities.

All finding details can be found in the DryRun Security Dashboard.

mtesauro
mtesauro approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit f751349 into DefectDojo:dev Apr 11, 2025
78 checks passed
@Maffooch Maffooch deleted the import-payload branch April 11, 2025 16:08
Maffooch added a commit that referenced this pull request Apr 21, 2025
@Maffooch
Import/Reimport Stats: Change name of left untouched (#12193)
1d52d25 
* Import/Reimport Stats: Change name of left untouched

* Update migrations

* Failed spell check

* Update migration again

* Migrate from `left_untouched` to `untouched`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneill cneill cneill approved these changes

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

Assignees
No one assigned
Labels
docs New Migration Adding a new migration file. Take care when merging. unittests
Projects
None yet
Milestone
2.46.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Maffooch @valentijnscholten @mtesauro @cneill @dogboat @hblankenship