Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(notif): Product name not rendered correctly #12203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix(notif): Product name not rendered correctly #12203

merged 1 commit into from
Apr 10, 2025

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Apr 9, 2025

Until now, the product's name has been rendered as None. Probably some old copy-paste issue.

@kiblik kiblik requested review from Maffooch and mtesauro as code owners April 9, 2025 14:06
@github-actions github-actions bot added the ui label Apr 9, 2025
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Apr 9, 2025

DryRun Security Summary

Two email notification templates were updated to use {{ engagement_product }} instead of {{product}}, improving product name display accuracy and implementing security best practices like Django's autoescape feature.

Expand for full summary

Summary: Two email notification templates for engagement events were updated, changing the product link text from {{product}} to {{ engagement_product }} to ensure accurate product name display.

Security Findings:
• Potential Information Disclosure Mitigation

  • Template change ensures correct product name is displayed
  • Could prevent potential misrepresentation of product information

• Template Security Mechanisms

  • Django's {% autoescape on %} helps prevent XSS
  • URL generation uses full_url filter for proper handling

• No Direct Security Vulnerabilities

  • No hardcoded credentials
  • No exposed internal hostnames
  • No configuration security issues detected

View PR in the DryRun Dashboard.

@Maffooch Maffooch added this to the 2.45.1 milestone Apr 9, 2025
@Maffooch Maffooch requested review from dogboat and hblankenship April 9, 2025 16:57
mtesauro
mtesauro approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit ebf0044 into DefectDojo:bugfix Apr 10, 2025
76 checks passed
@kiblik kiblik deleted the notif/broken_prod_name branch April 11, 2025 06:40
Maffooch pushed a commit that referenced this pull request Apr 21, 2025
@kiblik @Maffooch
fix(notif): Product name not rendered correctly (#12203)
125dc8f
Maffooch pushed a commit that referenced this pull request Apr 21, 2025
@kiblik @Maffooch
fix(notif): Product name not rendered correctly (#12203)
d4072a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtesauro mtesauro mtesauro approved these changes

@dogboat dogboat dogboat approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
2.45.1
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @mtesauro @dogboat @hblankenship @Maffooch