Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Linting: Update how-to-write-a-parser.md to not contain Ruff violations #12214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Linting: Update how-to-write-a-parser.md to not contain Ruff violations #12214

merged 1 commit into from
Apr 10, 2025

Conversation

valentijnscholten
Copy link
Member

The how-to-write-a-parser contained code that made Ruff unhappy.

@github-actions github-actions bot added the docs label Apr 10, 2025
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Apr 10, 2025 •
edited
Loading

DryRun Security Summary

A documentation patch updates type comparison code snippets in a parser writing guide from == to is to improve type identity checking and mitigate potential type-related logic errors.

Expand for full summary

Summary: A documentation patch modifies type checking code snippets in a parser writing guide, replacing == with is for more precise type comparisons in Python.

Security Findings:
• Potential Type-Related Vulnerability Mitigation

  • Location: docs/content/en/open_source/contributing/how-to-write-a-parser.md
  • Lines 177 and 192 modified
  • Risk: Potential for type-related logic errors in type comparisons
  • Explanation: Switching from == to is provides more precise type identity checking, reducing risk of unexpected type-based behavior

No additional concrete security vulnerabilities were found in the provided summary.

View PR in the DryRun Dashboard.

@valentijnscholten valentijnscholten changed the base branch from master to bugfix April 10, 2025 19:07
mtesauro
mtesauro approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 7098998 into bugfix Apr 10, 2025
147 of 148 checks passed
Maffooch pushed a commit that referenced this pull request Apr 21, 2025
@valentijnscholten @Maffooch
Update how-to-write-a-parser.md to not contain Ruff violations (#12214)
4af0965
Maffooch pushed a commit that referenced this pull request Apr 21, 2025
@valentijnscholten @Maffooch
Update how-to-write-a-parser.md to not contain Ruff violations (#12214)
aad8578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneill cneill cneill approved these changes

@mtesauro mtesauro mtesauro approved these changes

@hblankenship hblankenship hblankenship approved these changes

@Maffooch Maffooch Maffooch approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valentijnscholten @cneill @mtesauro @hblankenship @Maffooch