Release: Merge release into master from: release/2.45.3 #12324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….46.0-dev Release: Merge back 2.45.2 into bugfix from: master-into-bugfix/2.45.2-2.46.0-dev
* add examples_of_use content * reweight sidebar --------- Co-authored-by: Paul Osinski <[email protected]>
* Reimport: Special statuses should be respected from reports * Fixing ruff * Update unittests/tools/test_checkmarx_one_parser.py Co-authored-by: Charles Neill <[email protected]> * Use the correct dict for statuses --------- Co-authored-by: Charles Neill <[email protected]>
Co-authored-by: Paul Osinski <[email protected]>
* sla: parse finding.date implicitly * add comment * move import * add unit test
* fortify: handle suppressed findings * ruff * fortify: handle suppressed findings docs * fortify: handle suppressed findings docs
* 2.45.2 pro changelog * add nextgen finding enhancements documentation * Correcting messy conflict resolution * Update docs/content/en/changelog/changelog.md Co-authored-by: Charles Neill <[email protected]> * Update docs/content/en/working_with_findings/finding_priority.md Co-authored-by: Charles Neill <[email protected]> * Update finding_priority.md --------- Co-authored-by: Paul Osinski <[email protected]> Co-authored-by: Cody Maffucci <[email protected]> Co-authored-by: Charles Neill <[email protected]>
🔴 Risk threshold exceeded.This pull request involves sensitive edits to a template tag file, potential security improvements in finding status updates and date parsing, and proactive measures to mitigate HTML injection and XSS risks, while also revealing some details about DefectDojo Pro's prioritization methodology.
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
⚠️ Configured Codepaths Edit in dojo/templatetags/display_tags.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
💭 Unconfirmed Findings (5)
| Vulnerability | Potential Information Disclosure of Prioritization Methodology |
|---|---|
| Description | Detailed documentation reveals exact calculation method for finding priority and risk, which could help an attacker understand how DefectDojo Pro assesses security findings. Located in docs/content/en/working_with_findings/finding_priority.md. |
| Vulnerability | Potential Race Condition in Finding Status Updates |
|---|---|
| Description | Added code mitigates a potential race condition where status changes during reimport could be inadvertently discarded. Located in dojo/importers/default_reimporter.py. |
| Vulnerability | Potential Unsafe Date Parsing |
|---|---|
| Description | Use of dateutil.parser.parse() on untrusted input could lead to unexpected date interpretations and potential manipulation of date-related logic. Located in dojo/models.py. |
| Vulnerability | Potential Cross-Site Scripting (XSS) Risk with mark_safe() |
|---|---|
| Description | mark_safe() function bypasses Django's automatic HTML escaping, potentially introducing XSS vulnerabilities if JSON-dumped values contain user-controlled or untrusted input. Located in dojo/templatetags/as_json.py. |
| Vulnerability | Potential HTML Injection Mitigation |
|---|---|
| Description | Introduction of as_json_no_html_esc filter suggests proactive measures to prevent HTML injection by ensuring proper escaping of dynamic content in webhook notifications. Found in multiple webhook template files. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release triggered by
rossops