Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Color changes for better accessibility #12342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

littlesvensson
Copy link
Contributor

@littlesvensson littlesvensson commented Apr 29, 2025

Fixes #12341 (at the main pain points)

Description

  • Shapes of dropdown icons in forced-contrast mode are now recognizable
  • Colour of legend in graphs stays the same also in forced-contrast mode

Before:
Screenshot 2025-04-29 at 17 17 14
Screenshot 2025-04-29 at 17 16 51

After:
Screenshot 2025-05-02 at 09 56 19
Screenshot 2025-05-02 at 09 59 20

Copy link

dryrunsecurity bot commented Apr 29, 2025

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

@Maffooch
Copy link
Contributor

Maffooch commented May 1, 2025

The contrast issue for the default color scheme has been tricky for me. There was another PR with these same changes, and the colors just felt so foreign to me. For the sake of getting this PR passed, I think we should start with just the high contrast mode that would be set by the browser, and leave the default colors alone for now

@littlesvensson littlesvensson marked this pull request as draft May 2, 2025 07:47
@littlesvensson
Copy link
Contributor Author

Hi @Maffooch ,

now there are only change connected to the high contrast mode.

I completely understand that the colour changes might feel unfamiliar, especially since you've been working with the current palette for a long time. That said, it could be valuable to consider contrast improvements—particularly in the more extreme cases, like small green text on grey background in the dashboard. While accessibility scanners might not always catch these nuances, tools like Colour Contrast Analyser can help spot them easily and ensure a better experience for all users.

@littlesvensson littlesvensson marked this pull request as ready for review May 2, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants