Urllib3 upgrade + Rerecord JIra responses #12355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request contains a low-confidence finding related to potential information disclosure in a test fixture, where network interaction logs might inadvertently reveal internal testing infrastructure details. 💭 Unconfirmed Findings (1)
All finding details can be found in the DryRun Security Dashboard. |
valentijnscholten
approved these changes
May 1, 2025
dogboat
approved these changes
May 1, 2025
hblankenship
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, we saw that tests were failing in #12218 on the jira tests, so I had asserted that the issue was with the jira client based on the stack traces there found in the test. As it turns out, testing the jira instance creation and finding push flows manually on urllib 2.4.0 was a success, so that meant the unit tests may be the issue. Sure enough, rerecording the tests allowed for successful tests execution
Big thanks to @dogboat for doing the testing to figure out the jira client is not the issue here!
[sc-11031]