helm chart publisher: use proper ref for checkout #12392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request contains a potential workflow injection risk in the GitHub Actions workflow file where an attacker might manipulate the release number input to specify arbitrary branches during checkout, which could introduce a security vulnerability if proper input validation is not implemented. 💭 Unconfirmed Findings (1)
All finding details can be found in the DryRun Security Dashboard. |
mtesauro
previously approved these changes
May 6, 2025
They seem to pass. |
Maffooch
approved these changes
May 6, 2025
hblankenship
approved these changes
May 6, 2025
dogboat
approved these changes
May 7, 2025
Maffooch
added a commit
that referenced
this pull request
May 7, 2025
* Update versions in application files * ui: fix "retrieve my username" typo (#12368) * Minor Semgrep connector docs tweaks (#12373) * jira push: log inactive/verified message to debug (#12376) * helm chart publisher: use proper ref for checkout (#12392) * tags: prevent validation from removing tags (#12400) * tags: prevent validation from removing tags * tags: prevent validation from removing tags smoke test * tags: prevent validation from removing tags smoke test * tags: prevent validation from removing tags remove ui test * Update versions in application files --------- Co-authored-by: DefectDojo release bot <[email protected]> Co-authored-by: Cody Maffucci <[email protected]> Co-authored-by: Jean-François YUEN <[email protected]> Co-authored-by: Charles Neill <[email protected]> Co-authored-by: valentijnscholten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm chart publish step had a hardcoded
ref: masteron the checkout step.Now that we have the
nightly-devbuilds merged and enabled, this means the wrong ref is checked out for the helm cart publishing. It overwrites the latest release info in the helm chart.This PR fixes the checkout ref.
For now I have disabled the
nightly-devbuilds and I've regenerated the helm-chart for 2.46.0:Thanks @kiblik for raising this and working together on a fix.