@vimeo/player/index.d.ts

Checklist

• is correct naming convention?
  • https://www.npmjs.com/package/@vimeo
  • http://bower.io/search/?q=@vimeo
  • others?
• has a test file? (@vimeo-tests.ts or @vimeo-tests.tsx)
• pass the Travis CI test?

This should go in types/vimeo__player. See microsoft/TypeScript#15051.

I tried as suggested. updated VSC Workspace to typescript 2.3.0. but scoped module is not found in my test.ts file. (with updated tsconfig to "baseUrl": "types" etc…).

That feature won't be out until 2.3.1. This could either wait, or use declare module "@vimeo/player { }.
This branch now contains commits that aren't yours. Please rebase to include just your changes. (Be sure to make a backup first.)

thanks for the help. hope now it is as needed.

travis failed: Could not parse version: line is '// TypeScript Version: 2.3'
should i just delete it for now till typescript 2.3 is out?

Yes, and be sure to run npm run lint vimeo__player.

hm, with npm run lint vimeo__player getting following error:

Warning: Text includes DefinitelyTyped link, but '--dt' is not set.
Failed to load /Users/[…]/types/vimeo__player/tslint.json: Invalid "extends" configuration value - could not require "dtslint/dt.json". Review the Node lookup algorithm (https://nodejs.org/api/modules.html#modules_all_together) for the approximate method TSLint uses to find the referenced configuration file.

Looks like you're using an older version of dtslint, just reinstall.

ok, reinstalled, but getting following error Object.entries is not a function

Upgrade your node version too. It should have warned about that on install.

I'm sorry for my inability to fix this. Finally resolved all errors except for:
ERROR: 6:1 no-single-declare-module File has only 1 module declaration — write it as an external module.

Just add a // tslint:disable-next-line no-single-declare-module above the declare module, since you need it until 2.3.1 is published.

Thanks!

Thanks a lot!
One last question: I tried adding the typings to my recent angular project. the types get recognized just fine, but on compiler time i get the /node_modules/@vimeo/player/dist/player.js' implicitly has an 'any' type. error…
I think it's because of the naming "vimeo__player".
should i open a new issue?

It looks like module resolution for an import in your code resolved to a JS file and didn't find any declaration to resolve to.
If you tried importing e.g. import * as p from "@vimeo/player/dist/player", that would explain the problem since the type declaration here doesn't declare such a module; it just declares @vimeo/player.

unfortunalty no. I'm importing the same way as in my test.ts file. import { Player } from '@vimeo/player';
VSC finds the installed typings correctly. I even added the "vimeo__player" to the compilerOptiony >> types.
Could not find a declaration file for module '@vimeo/player'. '/Users/[…]/frontend/node_modules/@vimeo/player/dist/player.js' implicitly has an 'any' type.

ok, i looked at another type-definition and they made it like this:

typescriptdeclare namespace Player { }

declare module '@vimeo/player' {
	export = Player;
}

declare module '@vimeo/player/dist/player' {
	export = Player;
}

you think that would fix the problem?
In the "@vimeo/player" library itself the package.json defines "types": "dist/player"

What other type definition? ❓
Try turning on --traceResolution to see where /node_modules/@vimeo/player/dist/player.js is getting imported in your code.

in the @types/mapbox-gl they declare it this way

Oh, thought you meant another definition for the same module.
For mapbox-gl they must have intended for someone to be able to import * as gl from "mapbox-gl/dist/mapbox-gl", but if you're not actually directly importing from there it shouldn't be relevant...

Oh, no sorry for confusion. :)

i tried the traceResolution option, but it just shows the error in the component where I'm importing the "@vimeo/player"

Error at /Users/…/frontend/src/app/shared/vimeo-video/vimeo-video.component.ts:4:24: Could not find a declaration file for module '@vimeo/player'. '/Users/…/frontend/node_modules/@vimeo/player/dist/player.js' implicitly has an 'any' type.
Error at /Users/…/frontend/aot/src/app/shared/vimeo-video/vimeo-video.component.ngfactory.ts:12:26: Could not find a declaration file for module '@vimeo/player/dist/player'. '/Users/…/frontend/node_modules/@vimeo/player/dist/player.js' implicitly has an 'any' type.
Error at /Users/…/frontend/aot/src/app/page/main/element/element.component.ngfactory.ts:16:26: Could not find a declaration file for module '@vimeo/player/dist/player'. '/Users/…/frontend/node_modules/@vimeo/player/dist/player.js' implicitly has an 'any' type.

I'm nowhere declaring /dist/player.js to be imported, so it must happen in-between.
the only place I find /dist/player.js is in the plugin itself in the package.json '"types": "dist/player"'

{
  "compilerOptions": {
    "target": "es5",
    "module": "es2015",
    "moduleResolution": "node",
    "sourceMap": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["es2015", "dom"],
    "noImplicitAny": true,
    "suppressImplicitAnyIndexErrors": true,
    "types": [
      "node",
      "clipboard",
      "vimeo__player"
    ]
  },

  "files": [
    "src/app/app.module.ts",
    "src/main-aot.ts"
  ],

  "angularCompilerOptions": {
   "genDir": "aot",
   "skipMetadataEmit" : true
 }
}

It looks like module resolution is correctly resolving it as a JS module, but only because it didn't find the types first. Are you sure you've correctly included those types? --listFiles would show you if it's lincluded.

@rugdealer That looks like a run-time error, not a compile error.

Actually we had similar problems with it. I think the problem could be found here https://github.com/vimeo/player.js#using-with-a-module-bundler >> window.Vimeo

Is there a way we could add the Vimeo-Namespace but still using this.player = new Player(…)?

The Vimeo-API Sets a global Vimeo Namespace in which the Player Class exist. Typings for Vimeo.Player would cause typescript compiler to fail with error, Typings for Player fail on runtime…